Add lisa runbook generator prompt, reduce the size of test writer prompt#4476
Add lisa runbook generator prompt, reduce the size of test writer prompt#4476paxue wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub prompt for generating LISA runbook YAML and trims the existing LISA test-writer prompt to be shorter while keeping core guidance.
Changes:
- Reduced
.github/prompts/lisa_test_writer.prompt.mdfrom a long guide to a condensed checklist + skeleton. - Added
.github/prompts/lisa_runbook_generator.prompt.mdwith runbook structure, platform/testcase examples, and common scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| .github/prompts/lisa_test_writer.prompt.md | Condenses test-writing guidance and keeps a short example skeleton. |
| .github/prompts/lisa_runbook_generator.prompt.md | Introduces a runbook-YAML generator prompt with examples and rules. |
reduce the lisa_test_writer prompt file
1c7e981 to
d699c67
Compare
| 1. **What tests?** (specific test name, area, smoke, tier — or passed via CLI variable) | ||
| 2. **What platform?** (azure, ready, qemu, openvmm) | ||
| 3. **What images?** (see Image Formats below) | ||
| 4. **Special requirements?** (security profile, WSL, purchase plan, disk/NIC) |
There was a problem hiding this comment.
Add the questions about azure auth
| **VHD** — custom OS disk from a storage blob URL: | ||
| ```yaml | ||
| vhd: | ||
| vhd_path: "https://mystorageaccount.blob.core.windows.net/vhds/my-image.vhd" |
There was a problem hiding this comment.
need specify the vhd generation and architecture, also need to mention when use arm64 vhd, either use shared gallery image or use gallery image transformer.
| platform: | ||
| - type: azure | ||
| admin_username: $(admin_username) | ||
| admin_password: $(admin_password) |
There was a problem hiding this comment.
encourage to use admin_private_key_file or leave it empty, lisa will generate the key pairs during runtime.
| | Azure Linux 3 | `microsoftcblmariner azure-linux-3 azure-linux-3 latest` | | ||
| | Debian 12 Gen2 | `debian debian-12 12-gen2 latest` | | ||
| | SLES 15 SP6 Gen2 | `suse sles-15-sp6 gen2 latest` | | ||
| | Windows Server 2022 Gen2 | `MicrosoftWindowsServer WindowsServer 2022-datacenter-g2 latest` | |
There was a problem hiding this comment.
when use windows image, is_linux needs to be set as false
| |---------|---------| | ||
| | `name` | Descriptive run name | | ||
| | `include` | Inherit from other YAML files: `- path: ./azure.yml` | | ||
| | `extension` | Extra test module paths: `- "../testsuites"` | |
There was a problem hiding this comment.
This needs to be expanded, when I use the prompt, it doesn't generate the section.
| | `name` | Descriptive run name | | ||
| | `include` | Inherit from other YAML files: `- path: ./azure.yml` | | ||
| | `extension` | Extra test module paths: `- "../testsuites"` | | ||
| | `variable` | Parameters with `$(name)` substitution. Supports `is_secret: true`, `file: ./secrets.yml` | |
There was a problem hiding this comment.
need to add is_case_visible
This reverts commit d699c67.
This reverts commit 607828b.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results