OpenSSL speed test false failure fix#4470
Draft
umfranci wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes false failures in the OpenSSL speed test helper by replacing fragile stdout “error substring” scanning with a positive validation that benchmark output was produced.
Changes:
- Replace
":error:"stdout scanning with a check that"bytes per second"appears in the OpenSSL speed output. - Improve the failure message to indicate that no benchmark results were produced.
| raise LisaException( | ||
| f"OpenSSL speed test failed - errors found in output: {result.stdout}" | ||
| "OpenSSL speed test produced no benchmark results. " | ||
| f"Output: {result.stdout}" |
umfranci
changed the title
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed false test failures in
verify_openssl_speed_testcaused by scanning stdout for the substring:error:. When the system crypto policy disables legacy algorithms (e.g. DSA-SHA1), OpenSSL emits benign error lines likeError setting up context for dsa-sha1in stdout even though the overall speed test succeeds. The old code treated any:error:substring as a test failure.Replaced the fragile error-string scanning with positive output validation - the test now checks that
"bytes per second"appears in stdout (confirming at least one algorithm completed successfully) and continues to rely on the process exit code for actual failures.Type of Change
Checklist
Test Validation
Key Test Cases:
verify_openssl_speed_test
Impacted LISA Features:
Openssl
Tested Azure Marketplace Images:
Test Results