Fix resource disk detection for NVMe-only VM sizes#4461
Draft
umfranci wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Azure SKU-to-capability mapping so NVMe-only VM sizes are recognized as having local resource disk capacity even when MaxResourceVolumeMB is missing or zero. In the Azure orchestrator, that affects requirement matching and test scheduling for scenarios that depend on temporary/local storage.
Changes:
- Extend
_resource_sku_to_capabilityto checkNvmeDiskSizeInMiBin addition toMaxResourceVolumeMB. - Mark
has_resource_diskas true when either classic resource-disk capacity or NVMe local-disk capacity is present. - Keep the rest of the Azure capability synthesis flow unchanged.
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some NVME local disk VM sizes have a
NvmeDiskSizeInMiBcapability but theirMaxResourceVolumeMBis either absent or zero. As a result, LISA incorrectly setshas_resource_disk = Falsefor these VMs, causing test cases that depend on resource disk presence to be skipped or to fail.Fix
Updated the resource disk detection logic in
_resource_sku_to_capabilityto also check theNvmeDiskSizeInMiBAzure SKU capability. A VM size is now considered to have a resource disk if eitherMaxResourceVolumeMB > 0orNvmeDiskSizeInMiB > 0