Skip to content

Fix resource disk detection for NVMe-only VM sizes#4461

Draft
umfranci wants to merge 2 commits into
mainfrom
umfranci/nvme-disk-13042026
Draft

Fix resource disk detection for NVMe-only VM sizes#4461
umfranci wants to merge 2 commits into
mainfrom
umfranci/nvme-disk-13042026

Conversation

@umfranci
Copy link
Copy Markdown
Collaborator

@umfranci umfranci commented May 2, 2026

Problem

Some NVME local disk VM sizes have a NvmeDiskSizeInMiB capability but their MaxResourceVolumeMB is either absent or zero. As a result, LISA incorrectly sets has_resource_disk = False for these VMs, causing test cases that depend on resource disk presence to be skipped or to fail.

Fix

Updated the resource disk detection logic in _resource_sku_to_capability to also check the NvmeDiskSizeInMiB Azure SKU capability. A VM size is now considered to have a resource disk if either MaxResourceVolumeMB > 0 or NvmeDiskSizeInMiB > 0

Copilot AI review requested due to automatic review settings May 2, 2026 15:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Azure SKU-to-capability mapping so NVMe-only VM sizes are recognized as having local resource disk capacity even when MaxResourceVolumeMB is missing or zero. In the Azure orchestrator, that affects requirement matching and test scheduling for scenarios that depend on temporary/local storage.

Changes:

  • Extend _resource_sku_to_capability to check NvmeDiskSizeInMiB in addition to MaxResourceVolumeMB.
  • Mark has_resource_disk as true when either classic resource-disk capacity or NVMe local-disk capacity is present.
  • Keep the rest of the Azure capability synthesis flow unchanged.

Comment thread lisa/sut_orchestrator/azure/platform_.py
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

✅ AI Test Selection — PASSED

1 test case(s) selected (view run)

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Count
✅ Passed 1
❌ Failed 0
⏭️ Skipped 0
Total 1
Test case details
Test Case Status Time (s) Message
smoke_test (lisa_0_0) ✅ PASSED 41.233

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

✅ AI Test Selection — PASSED

1 test case(s) selected (view run)

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Count
✅ Passed 1
❌ Failed 0
⏭️ Skipped 0
Total 1
Test case details
Test Case Status Time (s) Message
smoke_test (lisa_0_0) ✅ PASSED 34.735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants