Reduce ntttcp performance log volume#4455
Open
vyadavmsft wants to merge 1 commit into
Open
Conversation
Expose the existing no_debug_log process option through the ntttcp and lagscope tool wrappers so noisy long-running performance commands can suppress per-line stdout logging without losing captured output. Enable the option in perf_ntttcp for the ntttcp server/client and lagscope latency sidecar commands. This keeps result parsing intact while reducing DEBUG file log growth during high-connection retry loops.
vyadavmsft
requested review from
LiliDeng,
johnsongeorge-w and
lubaihua33
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Expose the existing no_debug_log process option through the ntttcp and lagscope tool wrappers and enable it in perf_ntttcp to reduce noisy per-line DEBUG file logging during long-running performance runs while preserving captured output for parsing.
Changes:
- Add
no_debug_logparameters tontttcpandlagscopeserver/client execution helpers and pass through to process execution. - Enable
no_debug_log=Truefor the ntttcp server/client and lagscope latency sidecar invocations inperf_ntttcp.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lisa/tools/ntttcp.py | Threads no_debug_log through ntttcp server/client wrappers and passes it to async execution (and one wait path). |
| lisa/tools/lagscope.py | Adds no_debug_log to lagscope server/client APIs and passes it to execution for the lagscope-based implementation. |
| lisa/microsoft/testsuites/performance/common.py | Turns on no_debug_log=True for perf ntttcp’s ntttcp + lagscope subprocesses to reduce log volume. |
Comments suppressed due to low confidence (1)
lisa/tools/lagscope.py:1
- Similar to the server path,
no_debug_logis accepted but not used here, which makes the API contract inconsistent across lagscope implementations and can surprise callers trying to suppress debug logging. If the underlying Sockperf client supportsno_debug_log, pass it through; otherwise, add an explicit comment/docstring stating thatno_debug_log(and any other unsupported knobs) are intentionally ignored for this implementation.
# Copyright (c) Microsoft Corporation.
|
| Count | |
|---|---|
| ✅ Passed | 8 |
| ❌ Failed | 0 |
| ⏭️ Skipped | 13 |
| Total | 21 |
Test case details
| Test Case | Status | Time (s) | Message |
|---|---|---|---|
| perf_tcp_iperf_passthrough_host_guest (lisa_0_20) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_iperf_passthrough_host_guest (lisa_0_21) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_single_pps_passthrough_host_guest (lisa_0_22) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_max_pps_passthrough_host_guest (lisa_0_23) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_ntttcp_passthrough_host_guest (lisa_0_24) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_1k_ntttcp_passthrough_host_guest (lisa_0_25) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_iperf_passthrough_two_guest (lisa_0_26) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_iperf_passthrough_two_guest (lisa_0_27) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_single_pps_passthrough_two_guest (lisa_0_28) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_max_pps_passthrough_two_guest (lisa_0_29) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_ntttcp_passthrough_two_guest (lisa_0_30) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_1k_ntttcp_passthrough_two_guest (lisa_0_31) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_nested_hyperv_storage_singledisk (lisa_0_36) | ⏭️ SKIPPED | 0.000 | check skipped: OS type mismatch: ["requires [<class 'lisa.operating_system.Windows'>] but VM supports [<class 'lisa.oper |
| perf_nested_kvm_storage_singledisk (lisa_0_34) | ✅ PASSED | 5481.402 | |
| perf_ultra_datadisks_1024k (lisa_0_1) | ✅ PASSED | 1067.275 | |
| perf_resource_disk_1024k (lisa_0_8) | ✅ PASSED | 1621.147 | |
| perf_premiumv2_datadisks_1024k (lisa_0_3) | ✅ PASSED | 2457.130 | |
| perf_ultra_datadisks_4k (lisa_0_0) | ✅ PASSED | 4381.542 | |
| perf_premiumv2_datadisks_4k (lisa_0_2) | ✅ PASSED | 4383.544 | |
| perf_epoll (lisa_0_33) | ✅ PASSED | 187.190 | |
| perf_messaging (lisa_0_32) | ✅ PASSED | 2013.635 |
|
| Count | |
|---|---|
| ✅ Passed | 8 |
| ❌ Failed | 0 |
| ⏭️ Skipped | 13 |
| Total | 21 |
Test case details
| Test Case | Status | Time (s) | Message |
|---|---|---|---|
| perf_tcp_iperf_passthrough_host_guest (lisa_0_20) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_iperf_passthrough_host_guest (lisa_0_21) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_single_pps_passthrough_host_guest (lisa_0_22) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_max_pps_passthrough_host_guest (lisa_0_23) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_ntttcp_passthrough_host_guest (lisa_0_24) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_1k_ntttcp_passthrough_host_guest (lisa_0_25) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_iperf_passthrough_two_guest (lisa_0_26) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_iperf_passthrough_two_guest (lisa_0_27) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_single_pps_passthrough_two_guest (lisa_0_28) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_max_pps_passthrough_two_guest (lisa_0_29) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_tcp_ntttcp_passthrough_two_guest (lisa_0_30) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_udp_1k_ntttcp_passthrough_two_guest (lisa_0_31) | ⏭️ SKIPPED | 0.000 | requires [azure] but VM supports [cloud-hypervisor] |
| perf_nested_hyperv_storage_singledisk (lisa_0_36) | ⏭️ SKIPPED | 0.000 | check skipped: OS type mismatch: ["requires [<class 'lisa.operating_system.Windows'>] but VM supports [<class 'lisa.oper |
| perf_nested_kvm_storage_singledisk (lisa_0_34) | ✅ PASSED | 5509.040 | |
| perf_ultra_datadisks_1024k (lisa_0_1) | ✅ PASSED | 1069.017 | |
| perf_resource_disk_1024k (lisa_0_8) | ✅ PASSED | 1633.772 | |
| perf_premiumv2_datadisks_1024k (lisa_0_3) | ✅ PASSED | 2465.837 | |
| perf_premiumv2_datadisks_4k (lisa_0_2) | ✅ PASSED | 4375.886 | |
| perf_ultra_datadisks_4k (lisa_0_0) | ✅ PASSED | 4389.230 | |
| perf_epoll (lisa_0_33) | ✅ PASSED | 188.274 | |
| perf_messaging (lisa_0_32) | ✅ PASSED | 1963.871 |
Collaborator
|
@vyadavmsft this will fail the ntttcp case, please double check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the existing no_debug_log process option through the ntttcp and lagscope tool wrappers so noisy long-running performance commands can suppress per-line stdout logging without losing captured output.
Enable the option in perf_ntttcp for the ntttcp server/client and lagscope latency sidecar commands. This keeps result parsing intact while reducing DEBUG file log growth during high-connection retry loops.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results