Skip to content

Commit 67b9c6e

Browse files
committed
fix: improve naming
1 parent 283c1e4 commit 67b9c6e

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugSession.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ public VirtualMachine getVM() {
264264
}
265265

266266
@Override
267-
public boolean suspendAllThreads() {
267+
public boolean shouldSuspendAllThreads() {
268268
return suspendAllThreads;
269269
}
270270

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ public static CompletableFuture<Long> stopOnEntry(IDebugSession debugSession, St
416416
EventRequestManager manager = debugSession.getVM().eventRequestManager();
417417
MethodEntryRequest request = manager.createMethodEntryRequest();
418418
request.addClassFilter(mainClass);
419-
request.setSuspendPolicy(debugSession.suspendAllThreads() ? EventRequest.SUSPEND_ALL : EventRequest.SUSPEND_EVENT_THREAD);
419+
request.setSuspendPolicy(debugSession.shouldSuspendAllThreads() ? EventRequest.SUSPEND_ALL : EventRequest.SUSPEND_EVENT_THREAD);
420420

421421
debugSession.getEventHub().events().filter(debugEvent -> {
422422
return debugEvent.event instanceof MethodEntryEvent && request.equals(debugEvent.event.request());

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/IDebugSession.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ void setExceptionBreakpoints(boolean notifyCaught, boolean notifyUncaught, Strin
5757
* Returns whether breakpoints should suspend all threads or just the event thread.
5858
* This value is captured at session start and persists for the session lifetime.
5959
*/
60-
boolean suspendAllThreads();
60+
boolean shouldSuspendAllThreads();
6161
}

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/ThreadsRequestHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ private CompletableFuture<Response> resume(Requests.ContinueArguments arguments,
150150
thread = DebugUtility.getThread(context.getDebugSession(), arguments.threadId);
151151
}
152152

153-
if (context.getDebugSession().suspendAllThreads()) {
153+
if (context.getDebugSession().shouldSuspendAllThreads()) {
154154
thread = null;
155155
}
156156

0 commit comments

Comments
 (0)