Fix duplicate plugin application, simplify CI to use JDK 11, and fix DTS emulator connectivity (#248)

* Initial plan

* Initial plan

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Fix 'default messager has already been registered' warning

- Remove duplicate plugin application in samples-azure-functions/build.gradle
- Remove duplicate plugin application in endtoendtests/build.gradle
- Move 'java' plugin to plugins block
- Upgrade azure-functions plugin from 1.11.1 to 1.16.1

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Revert unintended changes to orchestrator_service.proto

The proto file was accidentally modified by the downloadProtoFiles task
during the build. This reverts it to the original state.

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Revert plugin version to 1.11.1 to fix Gradle 7.4 compatibility

The azure-functions plugin 1.16.1 brings in jackson-core 2.17.0 which
contains Java 21 class files that Gradle 7.4's ASM cannot handle.

Keep the duplicate plugin application removal fix which helps reduce
the "default messager" warning.

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Fix SpotBugs Java version - run with JDK 11

SpotBugs 4.9.2 requires Java 11+ (class file version 55.0) but the
workflow was running it with Java 8. Updated workflow to use JDK_11
environment variable for SpotBugs tasks.

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Fix SpotBugs - run build task with JDK 11 too

SpotBugs runs as part of the 'build' task, not just in the explicit
SpotBugs step. Updated the build step to also use JDK_11 since
SpotBugs 4.9.2 requires Java 11+.

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Update all CI jobs to use JDK 11

- Updated Integration Tests to use JDK_11
- Updated functions-e2e-tests job to use JDK 11 instead of JDK 8
- Updated functions-sample-tests job to use JDK 11 instead of JDK 8

Regarding Gradle 8.0: Upgrading would require also updating the
protobuf plugin from 0.8.16 to 0.9.x for full compatibility, which
is a larger change that could be done in a separate PR.

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Fix DTS emulator connectivity with proper health check loop

Replace fixed 10-second sleep with a robust health check that:
- Actively polls port 4001 using nc until the emulator is ready
- Allows up to 60 seconds for the emulator to start
- Provides better error diagnostics if startup fails
- Adds 5 extra seconds after port is open for gRPC initialization

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Use bash /dev/tcp for more portable health check

Address code review feedback:
- Replace nc with bash's /dev/tcp for portability
- Rename max_attempts to MAX_WAIT_SECONDS with comment
- Add comment explaining the TCP check mechanism

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

* Simplify Java setup: remove JDK 8, use only JDK 11

- Remove JDK 8 setup since it's not needed
- Remove JDK_11 environment variable workaround
- Remove all `export JAVA_HOME=$JDK_11` lines
- Upgrade setup-java from v2 to v4 in all jobs
- Workflow now uses only JDK 11 throughout

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>

Author: Copilot

.github/workflows/build-validation.yml

@@ -22,22 +22,11 @@ jobs:
     - uses: actions/checkout@v2
 
     - name: Set up JDK 11
-      uses: actions/setup-java@v2
+      uses: actions/setup-java@v4
       with:
         java-version: '11'
         distribution: 'microsoft'
 
-    - name: set JDK_11 environment variable test compiling and running
-      env:
-        ACTIONS_ALLOW_UNSECURE_COMMANDS: true
-      run: echo ::set-env name=JDK_11::$(echo $JAVA_HOME)
-
-    - name: Set up JDK 8
-      uses: actions/setup-java@v2
-      with:
-        java-version: '8'
-        distribution: 'temurin'
-
     - name: Setup Gradle
       uses: gradle/gradle-build-action@v2
 
@@ -56,9 +45,7 @@ jobs:
         if-no-files-found: ignore
 
     - name: Run Unit Tests with Gradle
-      run: |
-        export JAVA_HOME=$JDK_11
-        ./gradlew clean test || echo "UNIT_TEST_FAILED=true" >> $GITHUB_ENV
+      run: ./gradlew clean test || echo "UNIT_TEST_FAILED=true" >> $GITHUB_ENV
       continue-on-error: true
 
     - name: Upload test reports if tests failed
@@ -77,11 +64,31 @@ jobs:
       run: docker run --name durabletask-emulator -p 4001:8080 -d mcr.microsoft.com/dts/dts-emulator:latest
 
     - name: Display Durable Task Emulator Logs
-      run: nohup docker logs --since=0 durabletask-emulator > durabletask-emulator.log 2>&1 &
+      run: nohup docker logs -f durabletask-emulator > durabletask-emulator.log 2>&1 &
 
-      # wait for 10 seconds, so sidecar container can be fully up, this will avoid intermittent failing issues for integration tests causing by failed to connect to sidecar
-    - name: Wait for 10 seconds
-      run: sleep 10
+    - name: Wait for Durable Task Emulator to be ready
+      run: |
+        echo "Waiting for Durable Task Emulator to be ready on port 4001..."
+        # Maximum wait time of 60 seconds for emulator startup
+        MAX_WAIT_SECONDS=60
+        attempt=0
+        # Use bash's /dev/tcp for portability instead of nc
+        while ! (echo > /dev/tcp/localhost/4001) 2>/dev/null; do
+          attempt=$((attempt + 1))
+          if [ $attempt -ge $MAX_WAIT_SECONDS ]; then
+            echo "ERROR: Emulator not ready after $MAX_WAIT_SECONDS seconds"
+            echo "Docker container status:"
+            docker ps -a
+            echo "Container logs:"
+            docker logs durabletask-emulator 2>&1 | tail -50
+            exit 1
+          fi
+          echo "Attempt $attempt/$MAX_WAIT_SECONDS - waiting for emulator..."
+          sleep 1
+        done
+        echo "Durable Task Emulator is ready on port 4001"
+        # Give additional time for gRPC service to fully initialize after port is open
+        sleep 5
 
     - name: Integration Tests with Gradle
       run: ./gradlew integrationTest || echo "TEST_FAILED=true" >> $GITHUB_ENV
@@ -120,11 +127,11 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - name: Set up JDK 8
-        uses: actions/setup-java@v2
+      - name: Set up JDK 11
+        uses: actions/setup-java@v4
         with:
-          java-version: '8'
-          distribution: 'temurin'
+          java-version: '11'
+          distribution: 'microsoft'
 
       - name: Setup Gradle
         uses: gradle/gradle-build-action@v2
@@ -159,11 +166,11 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - name: Set up JDK 8
-        uses: actions/setup-java@v2
+      - name: Set up JDK 11
+        uses: actions/setup-java@v4
         with:
-          java-version: '8'
-          distribution: 'temurin'
+          java-version: '11'
+          distribution: 'microsoft'
 
       - name: Setup Gradle
         uses: gradle/gradle-build-action@v2

endtoendtests/build.gradle

@@ -1,8 +1,7 @@
 plugins {
+    id 'java'
     id "com.microsoft.azure.azurefunctions" version "1.11.1"
 }
-apply plugin: 'java'
-apply plugin: "com.microsoft.azure.azurefunctions"
 
 group 'com.durabletask.endtoend'
 version '0.0.0-SNAPSHOT'

samples-azure-functions/build.gradle

@@ -1,8 +1,7 @@
 plugins {
+    id 'java'
     id "com.microsoft.azure.azurefunctions" version "1.11.1"
 }
-apply plugin: 'java'
-apply plugin: "com.microsoft.azure.azurefunctions"
 
 group 'com.functions'
 version '0.1.0-SNAPSHOT'