Skip to content

Commit 2029997

Browse files
committed
fix
1 parent 2c0e3fb commit 2029997

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

client/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,7 @@ protobuf {
9494
}
9595
generateProtoTasks {
9696
all()*.plugins { grpc {} }
97-
if (project.gradle.startParameter.taskNames.any { it.contains('downloadProtoFiles') }) {
98-
all()*.dependsOn downloadProtoFiles
99-
}
97+
all()*.dependsOn downloadProtoFiles
10098
}
10199
}
102100

client/src/main/java/com/microsoft/durabletask/FailureDetails.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,10 @@ public FailureDetails getInnerFailure() {
143143
*/
144144
@Nullable
145145
public Map<String, Object> getProperties() {
146-
return this.properties;
146+
if (this.properties == null) {
147+
return null;
148+
}
149+
return Collections.unmodifiableMap(this.properties);
147150
}
148151

149152
/**

client/src/test/java/com/microsoft/durabletask/ErrorHandlingIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,7 @@ void innerExceptionDetailsArePreserved() throws TimeoutException {
388388
* Tests that a registered {@link ExceptionPropertiesProvider} extracts custom properties
389389
* from an activity exception into {@link FailureDetails#getProperties()}.
390390
*/
391+
@Disabled("Emulator (dts-emulator) does not yet support properties in activity-level TaskFailureDetails")
391392
@Test
392393
void customExceptionPropertiesInFailureDetails() throws TimeoutException {
393394
final String orchestratorName = "OrchestrationWithCustomException";
@@ -496,7 +497,7 @@ void orchestrationDirectExceptionWithProperties() throws TimeoutException {
496497
/**
497498
* Tests that custom properties survive through a parent -> sub-orchestration -> activity chain.
498499
*/
499-
@Disabled("Investigating emulator compatibility")
500+
@Disabled("Emulator (dts-emulator) does not yet support properties in activity-level TaskFailureDetails")
500501
@Test
501502
void nestedOrchestrationExceptionPropertiesPreserved() throws TimeoutException {
502503
final String parentOrchName = "ParentOrch";

0 commit comments

Comments
 (0)