Skip to content

Commit f69abd7

Browse files
committed
Code quality improvements: PEP 8 compliance and cleanup
- Rename single-letter test mock classes to descriptive names (PEP 8 compliance): * T -> MockToken (5 test files) * R -> MockResponse (1 test file) - Remove unused 'import time' statements from example files - Improves code readability and follows Python naming conventions - All 48 tests continue to pass
1 parent 59f4587 commit f69abd7

7 files changed

Lines changed: 12 additions & 15 deletions

File tree

examples/advanced/complete_walkthrough.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,6 @@ def _status_value_for_index(idx: int, use_french: bool):
423423
# 4) Query records via SQL (?sql parameter))
424424
print("Query (SQL via ?sql query parameter):")
425425
try:
426-
import time
427426
pause("Execute SQL Query")
428427

429428
def _run_query():

examples/advanced/pandas_integration.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,6 @@ def backoff_retry(op, *, delays=(0, 2, 5, 10, 20), retry_http_statuses=(400, 403
201201
# 4) Query records via SQL (Web API ?sql=)
202202
print("(Pandas) Query (SQL via Web API ?sql=):")
203203
try:
204-
import time
205-
206204
def _run_query():
207205
id_key = f"{logical}id"
208206
cols = f"{id_key}, {attr_prefix}_code, {attr_prefix}_amount, {attr_prefix}_when"

tests/unit/core/test_http_errors.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
class DummyAuth:
1010
def acquire_token(self, scope):
11-
class T: access_token = "x"
12-
return T()
11+
class MockToken: access_token = "x"
12+
return MockToken()
1313

1414
class DummyHTTP:
1515
def __init__(self, responses):
@@ -18,9 +18,9 @@ def request(self, method, url, **kwargs):
1818
if not self._responses:
1919
raise AssertionError("No more responses")
2020
status, headers, body = self._responses.pop(0)
21-
class R:
21+
class MockResponse:
2222
pass
23-
r = R()
23+
r = MockResponse()
2424
r.status_code = status
2525
r.headers = headers
2626
if isinstance(body, dict):

tests/unit/data/test_enum_optionset_payload.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88

99
class DummyAuth:
1010
def acquire_token(self, scope): # pragma: no cover - simple stub
11-
class T:
11+
class MockToken:
1212
access_token = "token"
13-
return T()
13+
return MockToken()
1414

1515
class DummyConfig:
1616
"""Minimal config stub providing attributes ODataClient.__init__ expects."""

tests/unit/data/test_logical_crud.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
class DummyAuth:
1010
def acquire_token(self, scope):
11-
class T: access_token = "x"
12-
return T()
11+
class MockToken: access_token = "x"
12+
return MockToken()
1313

1414
class DummyHTTPClient:
1515
def __init__(self, responses):

tests/unit/data/test_metadata_retry_logic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
class DummyAuth:
1212
def acquire_token(self, scope):
13-
class T:
13+
class MockToken:
1414
access_token = "test_token"
15-
return T()
15+
return MockToken()
1616

1717

1818
class TestMetadataRetryLogic:

tests/unit/data/test_sql_parse.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
class DummyAuth:
88
def acquire_token(self, scope):
9-
class T: access_token = "x" # no real token needed for parsing tests
10-
return T()
9+
class MockToken: access_token = "x" # no real token needed for parsing tests
10+
return MockToken()
1111

1212
def _client():
1313
return ODataClient(DummyAuth(), "https://org.example", None)

0 commit comments

Comments
 (0)