Update based on comments

Author: Abel Milash

src/PowerPlatform/Dataverse/data/_odata.py

@@ -1229,14 +1229,14 @@ def _request_metadata_with_retry(self, method: str, url: str, **kwargs):
                         continue
                     raise RuntimeError(f"Metadata request failed after {max_attempts} retries (404): {url}") from err
                 raise
-        raise RuntimeError(f"Metadata request failed: {url}")
 
     def _bulk_fetch_picklists(self, table_schema_name: str) -> None:
         """Fetch all picklist attributes and their options for a table in one API call.
 
         Uses collection-level PicklistAttributeMetadata cast to retrieve every picklist
         attribute on the table, including its OptionSet options. Populates the nested
         cache so that ``_convert_labels_to_ints`` resolves labels without further API calls.
+        The Dataverse metadata API does not page results.
         """
         table_key = self._normalize_cache_key(table_schema_name)
         now = time.time()

tests/unit/data/test_odata_internal.py

@@ -670,6 +670,21 @@ def test_bulk_fetch_makes_single_api_call(self):
         self.od._bulk_fetch_picklists("account")
         self.assertEqual(self.od._request.call_count, 1)
 
+    def test_bulk_fetch_stress_large_workload(self):
+        """Bulk fetch correctly parses a response with a large number of picklist attributes."""
+        num_picklists = 5000
+        picklists = [(f"new_pick{i}", [(100000000 + j, f"Option {j}") for j in range(4)]) for i in range(num_picklists)]
+        resp = self._bulk_response(*picklists)
+        self.od._request.return_value = resp
+
+        self.od._bulk_fetch_picklists("account")
+
+        self.assertEqual(self.od._request.call_count, 1)
+        cached = self.od._picklist_label_cache["account"]["picklists"]
+        self.assertEqual(len(cached), num_picklists)
+        self.assertEqual(cached["new_pick0"]["option 0"], 100000000)
+        self.assertEqual(cached[f"new_pick{num_picklists - 1}"]["option 3"], 100000003)
+
     # ---- _request_metadata_with_retry ----
 
     def test_retry_succeeds_on_first_try(self):