Complete docstring raises sections, add tests for all-NaN skip, index labels in errors, ID stripping

Author: Saurabh Badenkal

src/PowerPlatform/Dataverse/operations/dataframe.py

@@ -211,7 +211,12 @@ def update(
         :type clear_nulls: :class:`bool`
 
         :raises TypeError: If ``changes`` is not a pandas DataFrame.
-        :raises ValueError: If ``id_column`` is not found in the DataFrame.
+        :raises ValueError: If ``changes`` is empty, ``id_column`` is not found in the
+            DataFrame, ``id_column`` contains invalid (non-string, empty, or whitespace-only)
+            values, or no updatable columns exist besides ``id_column``.
+            Rows where all change values are NaN/None (after applying ``clear_nulls``)
+            are silently skipped. If all rows are skipped, the method returns without
+            making an API call.
 
         .. tip::
             All rows are sent in a single ``UpdateMultiple`` request (or a
@@ -294,6 +299,8 @@ def delete(
         :type use_bulk_delete: :class:`bool`
 
         :raises TypeError: If ``ids`` is not a pandas Series.
+        :raises ValueError: If ``ids`` contains invalid (non-string, empty, or
+            whitespace-only) values.
 
         :return: BulkDelete job ID when deleting multiple records via BulkDelete; otherwise ``None``.
         :rtype: :class:`str` or None

tests/unit/test_dataframe_operations.py

@@ -307,6 +307,49 @@ def test_update_clear_nulls_false(self):
         self.assertIn("name", changes)
         self.assertNotIn("telephone1", changes)
 
+    def test_update_all_nan_rows_skipped(self):
+        """When all change values are NaN for every row, no API call is made."""
+        df = pd.DataFrame(
+            [
+                {"accountid": "guid-1", "telephone1": None, "websiteurl": None},
+                {"accountid": "guid-2", "telephone1": None, "websiteurl": None},
+            ]
+        )
+        self.client.dataframe.update("account", df, id_column="accountid")
+        self.client._odata._update.assert_not_called()
+        self.client._odata._update_by_ids.assert_not_called()
+
+    def test_update_partial_nan_rows_filtered(self):
+        """Rows where all changes are NaN are filtered; remaining rows proceed."""
+        df = pd.DataFrame(
+            [
+                {"accountid": "guid-1", "name": "Updated", "telephone1": None},
+                {"accountid": "guid-2", "name": None, "telephone1": None},
+            ]
+        )
+        self.client.dataframe.update("account", df, id_column="accountid")
+        self.client._odata._update.assert_called_once_with("account", "guid-1", {"name": "Updated"})
+
+    def test_update_invalid_ids_reports_index_labels(self):
+        """Error message reports DataFrame index labels, not positional indices."""
+        df = pd.DataFrame(
+            [
+                {"accountid": "guid-1", "name": "A"},
+                {"accountid": None, "name": "B"},
+            ],
+            index=["row_a", "row_b"],
+        )
+        with self.assertRaises(ValueError) as ctx:
+            self.client.dataframe.update("account", df, id_column="accountid")
+        self.assertIn("row_b", str(ctx.exception))
+
+    def test_update_strips_whitespace_from_ids(self):
+        """Leading/trailing whitespace in IDs is stripped before API call."""
+        df = pd.DataFrame([{"accountid": "  guid-1  ", "name": "Contoso"}])
+        self.client.dataframe.update("account", df, id_column="accountid")
+        call_args = self.client._odata._update.call_args[0]
+        self.assertEqual(call_args[1], "guid-1")
+
     def test_update_clear_nulls_true(self):
         """NaN values are sent as None in the update payload when clear_nulls=True."""
         df = pd.DataFrame([{"accountid": "guid-1", "name": "New Name", "telephone1": None}])
@@ -368,6 +411,19 @@ def test_delete_with_bulk_delete_false(self):
         self.assertIsNone(result)
         self.assertEqual(self.client._odata._delete.call_count, 2)
 
+    def test_delete_invalid_ids_reports_index_labels(self):
+        """Error message reports Series index labels, not positional indices."""
+        ids = pd.Series(["guid-1", None], index=["row_x", "row_y"])
+        with self.assertRaises(ValueError) as ctx:
+            self.client.dataframe.delete("account", ids)
+        self.assertIn("row_y", str(ctx.exception))
+
+    def test_delete_strips_whitespace_from_ids(self):
+        """Leading/trailing whitespace in IDs is stripped before API call."""
+        ids = pd.Series(["  guid-1  "])
+        self.client.dataframe.delete("account", ids)
+        self.client._odata._delete.assert_called_once_with("account", "guid-1")
+
 
 class TestDataFrameEndToEnd(unittest.TestCase):
     """End-to-end mocked flow: create -> get -> update -> delete."""