Address PR review comments from abelmilash-msft

- Fix pip install command in batch example (PowerPlatform-Dataverse-Client)
- Hoist entity_set call above if-check in _resolve_record_create
- Extract _require_entity_metadata helper for duplicate table lookups
- Add inline comment explaining 400 in expected status codes
- Add annotation explaining why example 5 is commented out
- Populate __all__ in operations/batch.py with public classes
- Use _GUID_RE from _odata.py for consistent GUID regex
- Add _resolve_record_update tests (single, multiple, invalid changes)
- Add delete tests (multiple IDs, no-bulk, empty list, empty strings)

Author: Saurabh Badenkal

examples/advanced/batch.py

@@ -8,7 +8,7 @@
 HTTP request to the Dataverse Web API.
 
 Requirements:
-    pip install "PowerPlatform.Dataverse" azure-identity
+    pip install PowerPlatform-Dataverse-Client azure-identity
 """
 
 from __future__ import annotations
@@ -144,7 +144,8 @@
 
 print("\n[INFO] Example 5: Mixed batch")
 
-# Assume account_id exists
+# NOTE: Commented out because it requires a pre-existing account_id.
+# Uncomment and set account_id to run this example.
 # batch = client.batch.new()
 #
 # with batch.changeset() as cs:

src/PowerPlatform/Dataverse/data/_batch.py

@@ -276,6 +276,10 @@ def execute(
             url,
             data=body.encode("utf-8"),
             headers=headers,
+            # 400 is expected: Dataverse returns 400 for top-level batch
+            # errors (e.g. malformed body). We parse the response body to
+            # surface the service error via _parse_batch_response /
+            # _raise_top_level_batch_error rather than letting _request raise.
             expected=(200, 202, 207, 400),
         )
         return self._parse_batch_response(response)
@@ -353,10 +357,9 @@ def _resolve_one(self, item: Any) -> _RawRequest:
     # ------------------------------------------------------------------
 
     def _resolve_record_create(self, op: _RecordCreate) -> List[_RawRequest]:
+        entity_set = self._od._entity_set_from_schema_name(op.table)
         if isinstance(op.data, dict):
-            entity_set = self._od._entity_set_from_schema_name(op.table)
             return [self._od._build_create(entity_set, op.table, op.data, content_id=op.content_id)]
-        entity_set = self._od._entity_set_from_schema_name(op.table)
         return [self._od._build_create_multiple(entity_set, op.table, op.data)]
 
     def _resolve_record_update(self, op: _RecordUpdate) -> List[_RawRequest]:
@@ -398,17 +401,22 @@ def _resolve_record_upsert(self, op: _RecordUpsert) -> List[_RawRequest]:
     #  specific lookups needed before the relevant _build_* call)
     # ------------------------------------------------------------------
 
-    def _resolve_table_create(self, op: _TableCreate) -> List[_RawRequest]:
-        return [self._od._build_create_entity(op.table, op.columns, op.solution, op.primary_column)]
-
-    def _resolve_table_delete(self, op: _TableDelete) -> List[_RawRequest]:
-        ent = self._od._get_entity_by_table_schema_name(op.table)
+    def _require_entity_metadata(self, table: str) -> str:
+        """Look up MetadataId for *table*, raising MetadataError if not found."""
+        ent = self._od._get_entity_by_table_schema_name(table)
         if not ent or not ent.get("MetadataId"):
             raise MetadataError(
-                f"Table '{op.table}' not found.",
+                f"Table '{table}' not found.",
                 subcode=METADATA_TABLE_NOT_FOUND,
             )
-        return [self._od._build_delete_entity(ent["MetadataId"])]
+        return ent["MetadataId"]
+
+    def _resolve_table_create(self, op: _TableCreate) -> List[_RawRequest]:
+        return [self._od._build_create_entity(op.table, op.columns, op.solution, op.primary_column)]
+
+    def _resolve_table_delete(self, op: _TableDelete) -> List[_RawRequest]:
+        metadata_id = self._require_entity_metadata(op.table)
+        return [self._od._build_delete_entity(metadata_id)]
 
     def _resolve_table_get(self, op: _TableGet) -> List[_RawRequest]:
         return [self._od._build_get_entity(op.table)]
@@ -417,25 +425,12 @@ def _resolve_table_list(self, op: _TableList) -> List[_RawRequest]:
         return [self._od._build_list_entities(filter=op.filter, select=op.select)]
 
     def _resolve_table_add_columns(self, op: _TableAddColumns) -> List[_RawRequest]:
-        ent = self._od._get_entity_by_table_schema_name(op.table)
-        if not ent or not ent.get("MetadataId"):
-            raise MetadataError(
-                f"Table '{op.table}' not found.",
-                subcode=METADATA_TABLE_NOT_FOUND,
-            )
-        return [
-            self._od._build_create_column(ent["MetadataId"], col_name, dtype) for col_name, dtype in op.columns.items()
-        ]
+        metadata_id = self._require_entity_metadata(op.table)
+        return [self._od._build_create_column(metadata_id, col_name, dtype) for col_name, dtype in op.columns.items()]
 
     def _resolve_table_remove_columns(self, op: _TableRemoveColumns) -> List[_RawRequest]:
         columns = [op.columns] if isinstance(op.columns, str) else list(op.columns)
-        ent = self._od._get_entity_by_table_schema_name(op.table)
-        if not ent or not ent.get("MetadataId"):
-            raise MetadataError(
-                f"Table '{op.table}' not found.",
-                subcode=METADATA_TABLE_NOT_FOUND,
-            )
-        metadata_id = ent["MetadataId"]
+        metadata_id = self._require_entity_metadata(op.table)
         requests: List[_RawRequest] = []
         for col_name in columns:
             attr_meta = self._od._get_attribute_metadata(

src/PowerPlatform/Dataverse/operations/batch.py

@@ -44,7 +44,16 @@
 if TYPE_CHECKING:
     from ..client import DataverseClient
 
-__all__ = []
+__all__ = [
+    "BatchRecordOperations",
+    "BatchTableOperations",
+    "BatchQueryOperations",
+    "BatchDataFrameOperations",
+    "BatchRequest",
+    "BatchOperations",
+    "ChangeSet",
+    "ChangeSetRecordOperations",
+]
 
 
 # ---------------------------------------------------------------------------

tests/unit/data/test_batch_serialization.py

@@ -14,6 +14,7 @@
     _RecordCreate,
     _RecordDelete,
     _RecordGet,
+    _RecordUpdate,
     _RecordUpsert,
     _TableGet,
     _TableList,
@@ -258,6 +259,88 @@ def test_resolve_record_delete_single(self):
         od._build_delete.assert_called_once_with("account", "guid-1", content_id=None)
         self.assertEqual(result, [mock_req])
 
+    def test_resolve_record_update_single(self):
+        client, od = self._client_and_od()
+        mock_req = MagicMock()
+        od._build_update.return_value = mock_req
+
+        op = _RecordUpdate(table="account", ids="guid-1", changes={"name": "Updated"})
+        result = client._resolve_record_update(op)
+
+        od._build_update.assert_called_once_with("account", "guid-1", {"name": "Updated"}, content_id=None)
+        self.assertEqual(result, [mock_req])
+
+    def test_resolve_record_update_multiple(self):
+        client, od = self._client_and_od()
+        mock_req = MagicMock()
+        od._build_update_multiple.return_value = mock_req
+
+        op = _RecordUpdate(
+            table="account",
+            ids=["guid-1", "guid-2"],
+            changes=[{"name": "A"}, {"name": "B"}],
+        )
+        result = client._resolve_record_update(op)
+
+        od._build_update_multiple.assert_called_once()
+        self.assertEqual(result, [mock_req])
+
+    def test_resolve_record_update_single_with_list_changes_raises(self):
+        client, od = self._client_and_od()
+        from PowerPlatform.Dataverse.core.errors import ValidationError
+
+        op = _RecordUpdate(table="account", ids="guid-1", changes=[{"name": "A"}])
+        with self.assertRaises(ValidationError):
+            client._resolve_record_update(op)
+
+    def test_resolve_record_delete_multiple_ids(self):
+        client, od = self._client_and_od()
+        mock_req = MagicMock()
+        od._build_delete_multiple.return_value = mock_req
+
+        op = _RecordDelete(table="account", ids=["guid-1", "guid-2", "guid-3"])
+        result = client._resolve_record_delete(op)
+
+        od._build_delete_multiple.assert_called_once_with("account", ["guid-1", "guid-2", "guid-3"])
+        self.assertEqual(result, [mock_req])
+
+    def test_resolve_record_delete_multiple_no_bulk(self):
+        client, od = self._client_and_od()
+        mock_req = MagicMock()
+        od._build_delete.return_value = mock_req
+
+        op = _RecordDelete(table="account", ids=["guid-1", "guid-2"], use_bulk_delete=False)
+        result = client._resolve_record_delete(op)
+
+        self.assertEqual(od._build_delete.call_count, 2)
+        self.assertEqual(len(result), 2)
+
+    def test_resolve_record_delete_empty_ids_returns_empty(self):
+        client, od = self._client_and_od()
+
+        op = _RecordDelete(table="account", ids=[])
+        result = client._resolve_record_delete(op)
+
+        self.assertEqual(result, [])
+
+    def test_resolve_record_delete_filters_empty_strings(self):
+        client, od = self._client_and_od()
+        mock_req = MagicMock()
+        od._build_delete_multiple.return_value = mock_req
+
+        op = _RecordDelete(table="account", ids=["guid-1", "", "guid-2", ""])
+        result = client._resolve_record_delete(op)
+
+        od._build_delete_multiple.assert_called_once_with("account", ["guid-1", "guid-2"])
+
+    def test_resolve_record_delete_all_empty_strings_returns_empty(self):
+        client, od = self._client_and_od()
+
+        op = _RecordDelete(table="account", ids=["", "", ""])
+        result = client._resolve_record_delete(op)
+
+        self.assertEqual(result, [])
+
     def test_resolve_table_get(self):
         client, od = self._client_and_od()
         mock_req = MagicMock()