Skip to content

Commit b9fad2a

Browse files
tpellissierclaude
andcommitted
Address Copilot review: add if_none_match=False for replacements, update docstring
- Set if_none_match=False on replacement uploads so overwrites succeed - Include 'files' in test_client_deprecations docstring namespace list Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 02674d3 commit b9fad2a

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

examples/advanced/file_upload.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ def get_dataset_info(file_path: Path):
245245
small_file_attr_schema,
246246
str(replacement_file),
247247
mode="small",
248+
if_none_match=False,
248249
)
249250
)
250251
print({"small_replace_upload_completed": True, "small_replace_source_size": replace_size_small})
@@ -314,6 +315,7 @@ def get_dataset_info(file_path: Path):
314315
chunk_file_attr_schema,
315316
str(replacement_file),
316317
mode="chunk",
318+
if_none_match=False,
317319
)
318320
)
319321
print({"chunk_replace_upload_completed": True})

tests/unit/test_client_deprecations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
66
Each deprecated method on the client should:
77
1. Emit a DeprecationWarning.
8-
2. Delegate to the correct namespace method (records / query / tables).
8+
2. Delegate to the correct namespace method (records / query / tables / files).
99
3. Return the expected value, including any backward-compatibility shims.
1010
"""
1111

0 commit comments

Comments
 (0)