Fix tuple unpacking for _request() calls returning telemetry data

Update internal _request() call sites to unpack (response, telemetry)
tuples after Phase 1 changes. Also use duck typing instead of
isinstance(x, list) for OperationResult compatibility.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: tpellissier

examples/advanced/file_upload.py

@@ -68,6 +68,7 @@ def log(call: str):
 _FILE_HASH_CACHE = {}
 ATTRIBUTE_VISIBILITY_DELAYS = (0, 3, 10, 20, 35, 50, 70, 90, 120)
 
+
 def file_sha256(path: Path):  # returns (hex_digest, size_bytes)
     try:
         m = _FILE_HASH_CACHE.get(path)
@@ -166,19 +167,15 @@ def backoff(op, *, delays=(0, 2, 5, 10, 20, 20)):
             result = op()
             if attempts > 1:
                 retry_count = attempts - 1
-                print(
-                    f"   [INFO] Backoff succeeded after {retry_count} retry(s); waited {total_delay}s total."
-                )
+                print(f"   [INFO] Backoff succeeded after {retry_count} retry(s); waited {total_delay}s total.")
             return result
         except Exception as ex:  # noqa: BLE001
             last = ex
             continue
     if last:
         if attempts:
             retry_count = max(attempts - 1, 0)
-            print(
-                f"   [WARN] Backoff exhausted after {retry_count} retry(s); waited {total_delay}s total."
-            )
+            print(f"   [WARN] Backoff exhausted after {retry_count} retry(s); waited {total_delay}s total.")
         raise last
 
 
@@ -227,7 +224,7 @@ def ensure_file_attribute_generic(schema_name: str, label: str, key_prefix: str)
             f"{odata.api}/EntityDefinitions({meta_id})/Attributes?$select=SchemaName&$filter="
             f"SchemaName eq '{schema_name}'"
         )
-        r = backoff(lambda: odata._request("get", url), delays=ATTRIBUTE_VISIBILITY_DELAYS)
+        r, _ = backoff(lambda: odata._request("get", url), delays=ATTRIBUTE_VISIBILITY_DELAYS)
         val = []
         try:
             val = r.json().get("value", [])
@@ -255,7 +252,7 @@ def ensure_file_attribute_generic(schema_name: str, label: str, key_prefix: str)
     }
     try:
         url = f"{odata.api}/EntityDefinitions({meta_id})/Attributes"
-        backoff(lambda: odata._request("post", url, json=payload), delays=ATTRIBUTE_VISIBILITY_DELAYS)
+        backoff(lambda: odata._request("post", url, json=payload)[0], delays=ATTRIBUTE_VISIBILITY_DELAYS)
         print({f"{key_prefix}_file_attribute_created": True})
         time.sleep(2)
         return True
@@ -285,7 +282,7 @@ def wait_for_attribute_visibility(logical_name: str, label: str):
             time.sleep(delay)
             waited += delay
         try:
-            resp = odata._request("get", probe_url)
+            resp, _ = odata._request("get", probe_url)
             try:
                 resp.json()
             except Exception:  # noqa: BLE001
@@ -313,7 +310,7 @@ def wait_for_attribute_visibility(logical_name: str, label: str):
     payload = {name_attr: "File Sample Record"}
     log(f"client.create('{table_schema_name}', payload)")
     created_ids = backoff(lambda: client.create(table_schema_name, payload))
-    if isinstance(created_ids, list) and created_ids:
+    if created_ids and len(created_ids) > 0:
         record_id = created_ids[0]
     else:
         raise RuntimeError("Unexpected create return; expected list[str] with at least one GUID")
@@ -363,7 +360,7 @@ def get_dataset_info(file_path: Path):
         dl_url_single = (
             f"{odata.api}/{entity_set}({record_id})/{small_file_attr_logical}/$value"  # raw entity_set URL OK
         )
-        resp_single = backoff(lambda: odata._request("get", dl_url_single))
+        resp_single, _ = backoff(lambda: odata._request("get", dl_url_single))
         content_single = resp_single.content or b""
         import hashlib  # noqa: WPS433
 
@@ -393,7 +390,7 @@ def get_dataset_info(file_path: Path):
             )
         )
         print({"small_replace_upload_completed": True, "small_replace_source_size": replace_size_small})
-        resp_single_replace = backoff(lambda: odata._request("get", dl_url_single))
+        resp_single_replace, _ = backoff(lambda: odata._request("get", dl_url_single))
         content_single_replace = resp_single_replace.content or b""
         downloaded_hash_replace = hashlib.sha256(content_single_replace).hexdigest() if content_single_replace else None
         hash_match_replace = (
@@ -435,7 +432,7 @@ def get_dataset_info(file_path: Path):
         dl_url_chunk = (
             f"{odata.api}/{entity_set}({record_id})/{chunk_file_attr_logical}/$value"  # raw entity_set for download
         )
-        resp_chunk = backoff(lambda: odata._request("get", dl_url_chunk))
+        resp_chunk, _ = backoff(lambda: odata._request("get", dl_url_chunk))
         content_chunk = resp_chunk.content or b""
         import hashlib  # noqa: WPS433
 
@@ -464,7 +461,7 @@ def get_dataset_info(file_path: Path):
             )
         )
         print({"chunk_replace_upload_completed": True})
-        resp_chunk_replace = backoff(lambda: odata._request("get", dl_url_chunk))
+        resp_chunk_replace, _ = backoff(lambda: odata._request("get", dl_url_chunk))
         content_chunk_replace = resp_chunk_replace.content or b""
         dst_hash_chunk_replace = hashlib.sha256(content_chunk_replace).hexdigest() if content_chunk_replace else None
         hash_match_chunk_replace = (

examples/basic/functional_testing.py

@@ -91,22 +91,16 @@ def wait_for_table_metadata(
                 odata._entity_set_from_schema_name(table_schema_name)
 
                 if attempt > 1:
-                    print(
-                        f"   [OK] Table metadata available after {attempt} attempts."
-                    )
+                    print(f"   [OK] Table metadata available after {attempt} attempts.")
                 return info
         except Exception:
             pass
 
         if attempt < retries:
-            print(
-                f"   Waiting for table metadata to publish (attempt {attempt}/{retries})..."
-            )
+            print(f"   Waiting for table metadata to publish (attempt {attempt}/{retries})...")
             time.sleep(delay_seconds)
 
-    raise RuntimeError(
-        "Table metadata did not become available in time. Please retry later."
-    )
+    raise RuntimeError("Table metadata did not become available in time. Please retry later.")
 
 
 def ensure_test_table(client: DataverseClient) -> Dict[str, Any]:
@@ -190,7 +184,7 @@ def test_create_record(client: DataverseClient, table_info: Dict[str, Any]) -> s
                     continue
                 raise
 
-        if isinstance(created_ids, list) and created_ids:
+        if created_ids and len(created_ids) > 0:
             record_id = created_ids[0]
             print(f"[OK] Record created successfully!")
             print(f"   Record ID: {record_id}")
@@ -229,9 +223,7 @@ def test_read_record(client: DataverseClient, table_info: Dict[str, Any], record
                 break
             except HttpError as err:
                 if getattr(err, "status_code", None) == 404 and attempt < retries:
-                    print(
-                        f"   Record not queryable yet (attempt {attempt}/{retries}). Retrying in {delay_seconds}s..."
-                    )
+                    print(f"   Record not queryable yet (attempt {attempt}/{retries}). Retrying in {delay_seconds}s...")
                     time.sleep(delay_seconds)
                     continue
                 raise
@@ -301,9 +293,7 @@ def test_query_records(client: DataverseClient, table_info: Dict[str, Any]) -> N
                 break
             except HttpError as err:
                 if getattr(err, "status_code", None) == 404 and attempt < retries:
-                    print(
-                        f"   Query retry {attempt}/{retries} after metadata 404 ({err}). Waiting {delay_seconds}s..."
-                    )
+                    print(f"   Query retry {attempt}/{retries} after metadata 404 ({err}). Waiting {delay_seconds}s...")
                     time.sleep(delay_seconds)
                     continue
                 raise
@@ -373,9 +363,7 @@ def cleanup_test_data(client: DataverseClient, table_info: Dict[str, Any], recor
                     print("[OK] Test table deleted successfully (404 reported).")
                     break
                 if attempt < retries:
-                    print(
-                        f"   Table delete retry {attempt}/{retries} after error ({err}). Waiting {delay_seconds}s..."
-                    )
+                    print(f"   Table delete retry {attempt}/{retries} after error ({err}). Waiting {delay_seconds}s...")
                     time.sleep(delay_seconds)
                     continue
                 print(f"[WARN] Failed to delete test table: {err}")

src/PowerPlatform/Dataverse/data/_upload.py

@@ -145,7 +145,7 @@ def _upload_file_chunk(
             headers["If-None-Match"] = "null"
         else:
             headers["If-Match"] = "*"
-        r_init = self._request("patch", init_url, headers=headers, data=b"")
+        r_init, _ = self._request("patch", init_url, headers=headers, data=b"")
         location = r_init.headers.get("Location") or r_init.headers.get("location")
         if not location:
             raise RuntimeError("Missing Location header with sessiontoken for chunked upload")