Skip to content

Commit 6e8f0bb

Browse files
committed
PR comments
1 parent 40ec1c4 commit 6e8f0bb

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Auth:
4343
| `delete` | `delete(logical_name, list[id])` | `None` | Delete many (sequential). |
4444
| `query_sql` | `query_sql(sql)` | `list[dict]` | Constrained read-only SELECT via `?sql=`. |
4545
| `create_table` | `create_table(tablename, schema)` | `dict` | Creates custom table + columns. Friendly name (e.g. `SampleItem`) becomes schema `new_SampleItem`; explicit schema name (contains `_`) used as-is. |
46-
| `get_table_info` | `get_table_info(schema_name)` | `dict | None` | Basic table metadata by schema name (e.g. `new_SampleItem`). Friendly names not auto-converted (current limitation). |
46+
| `get_table_info` | `get_table_info(schema_name)` | `dict | None` | Basic table metadata by schema name (e.g. `new_SampleItem`). Friendly names not auto-converted. |
4747
| `list_tables` | `list_tables()` | `list[dict]` | Lists non-private tables. |
4848
| `delete_table` | `delete_table(tablename)` | `None` | Drops custom table. Accepts friendly or schema name; friendly converted to `new_<PascalCase>`. |
4949
| `PandasODataClient.create_df` | `create_df(logical_name, series)` | `str` | Create one record (returns GUID). |
@@ -160,7 +160,7 @@ for r in rows:
160160

161161
## Bulk create (CreateMultiple)
162162

163-
Pass a list of payloads to `create(entity_set, payloads)` to invoke the collection-bound `Microsoft.Dynamics.CRM.CreateMultiple` action. The method returns `list[str]` of created record IDs.
163+
Pass a list of payloads to `create(logical_name, payloads)` to invoke the collection-bound `Microsoft.Dynamics.CRM.CreateMultiple` action. The method returns `list[str]` of created record IDs.
164164

165165
```python
166166
# Bulk create accounts (returns list of GUIDs)

examples/quickstart_pandas.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ def backoff_retry(op, *, delays=(0, 2, 5, 10, 20), retry_http_statuses=(400, 403
102102
# Fail fast: all operations must use the custom table
103103
sys.exit(1)
104104

105-
entity_set = table_info.get("entity_set_name")
106-
logical = table_info.get("entity_logical_name") or entity_set.rstrip("s")
105+
logical = table_info.get("entity_logical_name")
107106
# Derive attribute logical name prefix from the entity logical name
108107
attr_prefix = logical.split("_", 1)[0] if "_" in logical else logical
109108
record_data = {

0 commit comments

Comments
 (0)