Skip to content

Commit 27f1af8

Browse files
Abel Milashclaude
andcommitted
Validate display_name and use explicit None check instead of truthiness fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 315cd34 commit 27f1af8

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

src/PowerPlatform/Dataverse/data/_odata.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1693,9 +1693,15 @@ def _create_table(
16931693
if not solution_unique_name:
16941694
raise ValueError("solution_unique_name cannot be empty")
16951695

1696+
if display_name is not None:
1697+
if not isinstance(display_name, str):
1698+
raise TypeError("display_name must be a string when provided")
1699+
if not display_name.strip():
1700+
raise ValueError("display_name cannot be empty")
1701+
16961702
metadata = self._create_entity(
16971703
table_schema_name=table_schema_name,
1698-
display_name=display_name or table_schema_name,
1704+
display_name=display_name if display_name is not None else table_schema_name,
16991705
attributes=attributes,
17001706
solution_unique_name=solution_unique_name,
17011707
)
@@ -2118,7 +2124,12 @@ def _build_create_entity(
21182124
subcode=VALIDATION_UNSUPPORTED_COLUMN_TYPE,
21192125
)
21202126
attributes.append(attr)
2121-
label = display_name or table
2127+
if display_name is not None:
2128+
if not isinstance(display_name, str):
2129+
raise TypeError("display_name must be a string when provided")
2130+
if not display_name.strip():
2131+
raise ValueError("display_name cannot be empty")
2132+
label = display_name if display_name is not None else table
21222133
body = {
21232134
"@odata.type": "Microsoft.Dynamics.CRM.EntityMetadata",
21242135
"SchemaName": table,

0 commit comments

Comments
 (0)