Address new Copilot review comments (round 3)

- Use VALIDATION_SQL_EMPTY constant instead of string literal in batch sql()
- Use VALIDATION_UNSUPPORTED_COLUMN_TYPE constant in all 3 _odata.py locations
- Import the constant from _error_codes.py
- Add input validation to _build_create_multiple (all items must be dicts)
- Narrow test assertions from Exception to ValidationError in test_odata_internal

Author: Saurabh Badenkal

src/PowerPlatform/Dataverse/data/_odata.py

@@ -30,6 +30,7 @@
     _is_transient_status,
     VALIDATION_SQL_NOT_STRING,
     VALIDATION_SQL_EMPTY,
+    VALIDATION_UNSUPPORTED_COLUMN_TYPE,
     METADATA_ENTITYSET_NOT_FOUND,
     METADATA_ENTITYSET_NAME_MISSING,
     METADATA_TABLE_NOT_FOUND,
@@ -1643,7 +1644,7 @@ def _create_columns(
             if not attr:
                 raise ValidationError(
                     f"Unsupported column type '{column_type}' for column '{column_name}'.",
-                    subcode="unsupported_column_type",
+                    subcode=VALIDATION_UNSUPPORTED_COLUMN_TYPE,
                 )
             if "OptionSet" in attr:
                 needs_picklist_flush = True
@@ -1759,6 +1760,8 @@ def _build_create_multiple(
         records: List[Dict[str, Any]],
     ) -> _RawRequest:
         """Build a CreateMultiple POST request without sending it."""
+        if not all(isinstance(r, dict) for r in records):
+            raise TypeError("All items for multi-create must be dicts")
         logical_name = table.lower()
         enriched = []
         for r in records:
@@ -2007,7 +2010,7 @@ def _build_create_entity(
             if not attr:
                 raise ValidationError(
                     f"Unsupported column type '{dtype}' for column '{col_name}'.",
-                    subcode="unsupported_column_type",
+                    subcode=VALIDATION_UNSUPPORTED_COLUMN_TYPE,
                 )
             attributes.append(attr)
         body = {
@@ -2078,7 +2081,7 @@ def _build_create_column(
         if not attr:
             raise ValidationError(
                 f"Unsupported column type '{dtype}' for column '{col_name}'.",
-                subcode="unsupported_column_type",
+                subcode=VALIDATION_UNSUPPORTED_COLUMN_TYPE,
             )
         return _RawRequest(
             method="POST",

src/PowerPlatform/Dataverse/operations/batch.py

@@ -10,6 +10,7 @@
 import pandas as pd
 
 from ..core.errors import ValidationError
+from ..core._error_codes import VALIDATION_SQL_EMPTY
 from ..data._batch import (
     _BatchClient,
     _ChangeSet,
@@ -538,7 +539,10 @@ def sql(self, sql: str) -> None:
             batch.query.sql("SELECT accountid, name FROM account WHERE name = 'Contoso'")
         """
         if not isinstance(sql, str) or not sql.strip():
-            raise ValidationError("sql must be a non-empty string", subcode="VALIDATION_SQL_EMPTY")
+            raise ValidationError(
+                "sql must be a non-empty string",
+                subcode=VALIDATION_SQL_EMPTY,
+            )
         self._batch._items.append(_QuerySql(sql=sql.strip()))
 
 

tests/unit/data/test_odata_internal.py

@@ -5,6 +5,7 @@
 import unittest
 from unittest.mock import MagicMock
 
+from PowerPlatform.Dataverse.core.errors import ValidationError
 from PowerPlatform.Dataverse.data._odata import _ODataClient
 
 
@@ -588,7 +589,7 @@ def test_multiple_targets_all_have_odata_id(self):
 
     def test_conflicting_key_field_raises(self):
         """Raises when a record field contradicts its alternate key value."""
-        with self.assertRaises(Exception) as ctx:
+        with self.assertRaises(ValidationError) as ctx:
             self.od._build_upsert_multiple(
                 "accounts",
                 "account",
@@ -599,7 +600,7 @@ def test_conflicting_key_field_raises(self):
 
     def test_mismatched_lengths_raises(self):
         """Raises when alternate_keys and records lengths differ."""
-        with self.assertRaises(Exception):
+        with self.assertRaises(ValidationError):
             self.od._build_upsert_multiple("accounts", "account", [{"accountnumber": "ACC-001"}], [])
 
     def test_url_contains_upsert_multiple_action(self):