Skip to content

Commit 216e07c

Browse files
committed
fix: improve formatting and error message clarity in file operations
1 parent 3a9dde8 commit 216e07c

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

src/PowerPlatform/Dataverse/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ def delete_file(
706706
707707
708708
:return: None
709-
:raises ~PowerPlatform.Dataverse.core.errors.HttpError: If the delete fails
709+
:raises ~PowerPlatform.Dataverse.core.errors.HttpError: If the delete fails
710710
711711
Example:
712712
Delete a file::
@@ -725,7 +725,7 @@ def delete_file(
725725
record_id,
726726
file_name_attribute,
727727
)
728-
728+
729729
# Cache utilities
730730
def flush_cache(self, kind) -> int:
731731
"""

src/PowerPlatform/Dataverse/data/_file_operations.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,14 @@ def _download_file(
195195

196196
key = self._format_key(record_id)
197197
url = f"{self.api}/{entity_set}{key}/{file_name_attribute}/$value"
198-
response = self._request("get", url, expected=(200,))
199-
file_name = response.headers.get('x-ms-file-name')
198+
response = self._request("get", url, expected=(200,))
199+
file_name = response.headers.get("x-ms-file-name")
200200
if file_name is None:
201-
raise ValueError("Response is missing the 'x-ms-file-name' header. The file column may be empty or the server did not return the expected header.")
201+
raise ValueError(
202+
"Response is missing the 'x-ms-file-name' header. The file column may be empty or the server did not return the expected header."
203+
)
202204
return file_name, response.content
203-
205+
204206
def _delete_file(
205207
self,
206208
entity_set: str,
@@ -218,6 +220,6 @@ def _delete_file(
218220

219221
key = self._format_key(record_id)
220222
url = f"{self.api}/{entity_set}{key}/{file_name_attribute}"
221-
self._request("delete", url, expected=(204,))
223+
self._request("delete", url, expected=(204,))
222224

223-
return None
225+
return None

0 commit comments

Comments
 (0)