Add edge case tests for batch failure propagation and missing AttributeType

Author: Abel Milash

tests/unit/data/test_odata_internal.py

@@ -647,6 +647,18 @@ def test_check_uses_crm_in_function_in_url(self):
         self.assertIn('"name"', call_url)
         self.assertIn('"industrycode"', call_url)
 
+    def test_check_missing_attribute_type_cached_as_non_picklist(self):
+        """Attribute with missing AttributeType in response is cached as non-picklist."""
+        mock_resp = MagicMock()
+        mock_resp.json.return_value = {"value": [{"LogicalName": "customfield"}]}  # no AttributeType key
+        self.od._request.return_value = mock_resp
+
+        self.od._check_attribute_types("account", ["customfield"])
+
+        entry = self.od._picklist_label_cache.get(("account", "customfield"))
+        self.assertIsNotNone(entry)
+        self.assertEqual(entry["map"], {})
+
     # ---- _optionset_map ----
 
     def test_optionset_returns_none_for_empty_table(self):
@@ -1099,6 +1111,15 @@ def test_convert_partial_cache_only_batches_uncached(self):
         # 1 batch (only industrycode) + 1 optionset fetch
         self.assertEqual(self.od._request.call_count, 2)
 
+    def test_convert_batch_failure_propagates(self):
+        """Server error during batch type-check propagates to caller."""
+        from PowerPlatform.Dataverse.core.errors import HttpError
+
+        self.od._request.side_effect = HttpError("Server Error", status_code=500)
+
+        with self.assertRaises(HttpError):
+            self.od._convert_labels_to_ints("account", {"name": "Contoso"})
+
     def test_convert_single_picklist_makes_two_api_calls(self):
         """Single picklist field (cold cache): 1 batch + 1 optionset = 2 total."""
         batch_resp = MagicMock()