Skip to content

Commit 76a3c0f

Browse files
authored
Merge pull request #2690 from microsoft/feat/hidi-log-warnings
feat: hidi validate command now logs warnings
2 parents fb6cecc + 62e7d56 commit 76a3c0f

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,7 @@ private static async Task<ReadResult> ParseOpenApiAsync(string openApiFile, bool
398398
logger.LogTrace("{Timestamp}ms: Completed parsing.", stopwatch.ElapsedMilliseconds);
399399

400400
LogErrors(logger, result);
401+
LogWarnings(logger, result);
401402
stopwatch.Stop();
402403
}
403404

@@ -652,7 +653,7 @@ private static string GetInputPathExtension(string? openapi = null, string? csdl
652653
private static void LogErrors(ILogger logger, ReadResult result)
653654
{
654655
var context = result.Diagnostic;
655-
if (context is not null && context.Errors.Count != 0)
656+
if (context is { Errors.Count: > 0 })
656657
{
657658
using (logger.BeginScope("Detected errors"))
658659
{
@@ -664,6 +665,21 @@ private static void LogErrors(ILogger logger, ReadResult result)
664665
}
665666
}
666667

668+
private static void LogWarnings(ILogger logger, ReadResult result)
669+
{
670+
var context = result.Diagnostic;
671+
if (context is { Warnings.Count: > 0 })
672+
{
673+
using (logger.BeginScope("Detected warnings"))
674+
{
675+
foreach (var warning in context.Warnings)
676+
{
677+
logger.LogWarning("Detected warning during parsing: {Warning}", warning.ToString());
678+
}
679+
}
680+
}
681+
}
682+
667683
internal static void WriteTreeDocumentAsMarkdown(string openapiUrl, OpenApiDocument document, StreamWriter writer)
668684
{
669685
var rootNode = OpenApiUrlTreeNode.Create(document, "main");

0 commit comments

Comments
 (0)