Skip to content

Extend build-time RuntimeAssets checks to include StringTools and NuGet APIs #353

@baronfel

Description

@baronfel

We need to expand the cases covered by

<MSBuildPackagesWithoutPrivateAssets
Include="@(PackageReference)"
Condition="!$([MSBuild]::ValueOrDefault('%(PackageReference.ExcludeAssets)', '').ToLower().Contains('runtime')) and
(
'%(PackageReference.Identity)' == 'Microsoft.Build' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Framework' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Utilities.Core' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Tasks.Core' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Engine' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Conversion.Core' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Runtime' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Localization' or
'%(PackageReference.Identity)' == 'Microsoft.Build.Engine'
)"/>
</ItemGroup>
to include the Stringtools library and NuGet libraries that the hosted instances of MSBuild that users bind to with Locator are expected to provide.

It would be ideal if there was some data-driven way to say "all of the dependencies of THING_X must be RuntimeAssets=exclude" to prevent these gaps in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions