table 111 "Sales Shipment Line" OnAfterInsertInvLineFromShptLine, OnInsertInvLineFromShptLineOnBeforeValidateQuantity, OnInsertInvLineFromShptLineOnAfterInsertAllLines

[Kotaite]

Why do you need this change?

At 4PS Construct, we require strict consistency between our event signatures and the actual usage in our codebase. The original integration events for OnAfterInsertInvLineFromShptLine, OnInsertInvLineFromShptLineOnBeforeValidateQuantity, and OnInsertInvLineFromShptLineOnAfterInsertAllLines did not use var for SalesShipmentLine parameter, which could lead to issues when event subscribers need to modify these records.

To ensure that event subscribers can properly modify the SalesShipmentLine parameters, we updated the event signatures to use var where necessary. This change aligns the event signatures with best practices and the actual requirements of our event subscribers.

Describe the request

Dear ALAppExtensions team,
On behalf of 4PS, I would like to request to add var for SalesShipmentLine parameter in OnAfterInsertInvLineFromShptLine, OnInsertInvLineFromShptLineOnBeforeValidateQuantity, and OnInsertInvLineFromShptLineOnAfterInsertAllLines events in table 111 "Sales Shipment Line"

Current code:

Suggested version:

Internal work item: [AB#615897](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615897)

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Summary: Add var modifier to SalesShipmentLine parameter in 3 existing events.

Note: Adding var to an existing event parameter is a non-breaking change - existing subscribers continue to work as before.

---

Implementation 1: OnAfterInsertInvLineFromShptLine

Update the event publisher signature:

[IntegrationEvent(false, false)]
local procedure OnAfterInsertInvLineFromShptLine(var SalesLine: Record "Sales Line"; SalesOrderLine: Record "Sales Line"; var NextLineNo: Integer; var SalesShipmentLine: Record "Sales Shipment Line")
begin
end;

---

Implementation 2: OnInsertInvLineFromShptLineOnBeforeValidateQuantity

Update the event publisher signature:

[IntegrationEvent(false, false)]
local procedure OnInsertInvLineFromShptLineOnBeforeValidateQuantity(var SalesShipmentLine: Record "Sales Shipment Line"; var SalesLine: Record "Sales Line"; var IsHandled: Boolean; var SalesInvHeader: Record "Sales Header")
begin
end;

---

Implementation 3: OnInsertInvLineFromShptLineOnAfterInsertAllLines

Update the event publisher signature:

[IntegrationEvent(false, false)]
local procedure OnInsertInvLineFromShptLineOnAfterInsertAllLines(var SalesShipmentLine: Record "Sales Shipment Line"; var SalesLine: Record "Sales Line"; var IsHandled: Boolean)
begin
end;

---

File: SalesShipmentLine.Table.al (table 111)

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 43688.