checkpatch: favor version of the script supplied by projects #873
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussenegger
reviewed
Dec 4, 2025
lua/lint/linters/checkpatch.lua
Outdated
Comment on lines
23
to
38
| local git_dir = vim.fs.find('.git', { | ||
| path = dir, | ||
| upward = true, | ||
| type = 'directory', | ||
| limit = 1, | ||
| })[1] | ||
|
|
||
| if git_dir then | ||
| local project_root = vim.fs.dirname(git_dir) | ||
| local tool_path = vim.fs.joinpath(project_root, 'scripts', tool_name) | ||
| if vim.fn.executable(tool_path) == 1 then | ||
| return tool_path | ||
| end | ||
| end | ||
|
|
||
| if vim.fn.executable(tool_name) == 1 then |
Owner
There was a problem hiding this comment.
Could you change this to only check ./scripts/checkpath.pl? Project root dir detection is out of scope for nvim-lint as managing root heuristics that fit everyone would be too much of a hassle to maintain. Users can provide a custom cwd as part of the try_lint call if cwd != project_root.
See also:
Author
There was a problem hiding this comment.
OK, I can do that. Would you be open to make linter's cwd a function? This way users would not need to map from file type to linter before calling try_lint() to decide whether they need to supply cwd
Linux kernel is not the only project that uses checkpatch.pl for patch validation, other projects (for example qemu) use it too, and their version is different from the one used by the kernel. Also checkpatch.pl changes from kernel version to kernel version when working with multiple versions, so requiring a single version covering everything is not practical. Additionally running checkpatch.pl on projects that do not use it and do not use kernel coding style is counter-productive. To solve this issue make the linter locate and favor the version of checkpatch.pl belonging to the project that file being linted belongs to. Also, if checkpatch.pl is not accessible use "true" as the command so that there are no errors/notifications and no diagnostic.
dtor
force-pushed
the
per-project-checkpatch
branch
from
39a63f1 to
661786a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux kernel is not the only project that uses checkpatch.pl for patch validation, other projects (for example qemu) use it too, and their version is different from the one used by the kernel. Also checkpatch.pl changes from kernel version to kernel version when working with multiple versions, so requiring a single version covering everything is not practical.
Additionally running checkpatch.pl on projects that do not use it and do not use kernel coding style is counter-productive.
To solve this issue make the linter locate and favor the version of checkpatch.pl belonging to the project that file being linted belongs to. Also, if checkpatch.pl is not accessible use "true" as the command so that there are no errors/notifications and no diagnostic.