fixup! STF-322: Add bounded transport-failure retry to WebServiceClient

Author: oschwald

src/main/java/com/maxmind/minfraud/WebServiceClient.java

@@ -28,7 +28,6 @@
 import java.net.http.HttpTimeoutException;
 import java.nio.charset.StandardCharsets;
 import java.time.Duration;
-import java.util.ArrayList;
 import java.util.Base64;
 import java.util.Collections;
 import java.util.HashMap;
@@ -386,20 +385,21 @@ private <T> T responseFor(String service, AbstractModel transaction, Class<T> cl
     private HttpResponse<InputStream> sendWithRetry(HttpRequest request)
         throws IOException, InterruptedException {
         int attempts = 0;
-        List<IOException> priors = new ArrayList<>();
+        IOException prior = null;
         while (true) {
             try {
                 return httpClient.send(request, HttpResponse.BodyHandlers.ofInputStream());
             } catch (IOException e) {
-                // Attach all prior IOExceptions directly so the final stack
-                // trace carries the full retry history without nesting.
-                for (IOException p : priors) {
-                    e.addSuppressed(p);
+                // Attach the immediate predecessor so the suppressed chain
+                // carries the full retry history (each link is the previous
+                // attempt's failure; walk via Throwable#getSuppressed).
+                if (prior != null) {
+                    e.addSuppressed(prior);
                 }
                 if (!isRetriableTransportFailure(e) || attempts >= maxRetries) {
                     throw e;
                 }
-                priors.add(e);
+                prior = e;
                 attempts++;
             }
         }