Skip to content

Conversation

@manojponnusamy2032-star
Copy link

@manojponnusamy2032-star manojponnusamy2032-star commented Dec 7, 2025

Fixes #4890

Technical details

Screenshots

Screenshot from 2025-12-08 15-22-45

This screenshot shows that the id column cannot be renamed anymore. The rename field is disabled/hidden as required

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

…n#1843)

- Add delete() method to RecordStore to call the delete API
- Add delete button to RecordPageContent with confirmation dialog
- Check DELETE privilege before allowing deletion
- Navigate back to table page after successful deletion
- Show success/error toast notifications
…ion#4890)

- Add validation in columns.patch() to prevent renaming the default
  Mathesar-added primary key column
- Raise ValidationError with clear message when rename is attempted
- Add comprehensive test case with mocking to verify the validation
  works correctly
- Fixes backend crash when users attempt to rename the ID column
- Replace 'docker-compose' with 'docker compose' in pr-tests.yml
- Remove unused ValidationError import from test_c_base.py
- Fix import order in RecordPageContent.svelte (external libs at top)
- Fix Prettier formatting in RecordPageContent.svelte imports
- Group by: external libs, stores, components, icons, api, systems, layouts, @mathesar-component-library
- Add blank lines between import groups per ESLint rules
- Move stores imports before all @Mathesar internal imports
- Ensure @mathesar-component-library appears last
- Remove blank lines between import groups in RecordPageContent.svelte (Prettier)
- Reorder imports to exact ESLint order: stores → components → icons → api → layouts → systems → @mathesar-component-library
- Remove trailing whitespace on blank lines in test_c_base.py (W293)
- Auto-fixed import order in RecordPageContent.svelte per ESLint rules
- Applied Prettier formatting to RecordPageContent.svelte
- All ESLint, Prettier, and flake8 checks now pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: review A PR awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to rename PK column named id

3 participants