-
-
Notifications
You must be signed in to change notification settings - Fork 456
Fix/4890 prevent id rename #5084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manojponnusamy2032-star
wants to merge
10
commits into
mathesar-foundation:develop
Choose a base branch
from
manojponnusamy2032-star:fix/4890-prevent-id-rename
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/4890 prevent id rename #5084
manojponnusamy2032-star
wants to merge
10
commits into
mathesar-foundation:develop
from
manojponnusamy2032-star:fix/4890-prevent-id-rename
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#1843) - Add delete() method to RecordStore to call the delete API - Add delete button to RecordPageContent with confirmation dialog - Check DELETE privilege before allowing deletion - Navigate back to table page after successful deletion - Show success/error toast notifications
…ion#4890) - Add validation in columns.patch() to prevent renaming the default Mathesar-added primary key column - Raise ValidationError with clear message when rename is attempted - Add comprehensive test case with mocking to verify the validation works correctly - Fixes backend crash when users attempt to rename the ID column
25e86a1 to
a5cd0d3
Compare
1b7bd5d to
b6575dd
Compare
- Replace 'docker-compose' with 'docker compose' in pr-tests.yml - Remove unused ValidationError import from test_c_base.py - Fix import order in RecordPageContent.svelte (external libs at top) - Fix Prettier formatting in RecordPageContent.svelte imports
- Group by: external libs, stores, components, icons, api, systems, layouts, @mathesar-component-library - Add blank lines between import groups per ESLint rules - Move stores imports before all @Mathesar internal imports - Ensure @mathesar-component-library appears last
- Remove blank lines between import groups in RecordPageContent.svelte (Prettier) - Reorder imports to exact ESLint order: stores → components → icons → api → layouts → systems → @mathesar-component-library - Remove trailing whitespace on blank lines in test_c_base.py (W293)
- Auto-fixed import order in RecordPageContent.svelte per ESLint rules - Applied Prettier formatting to RecordPageContent.svelte - All ESLint, Prettier, and flake8 checks now pass
de708e8 to
e7c036c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4890
Technical details
Screenshots
This screenshot shows that the id column cannot be renamed anymore. The rename field is disabled/hidden as required
Checklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin