Skip to content

Commit 7c679b8

Browse files
committed
Restore entrypoint, volume, and expose configurations
Signed-off-by: Moritz Mazetti <moritz@matchory.com>
1 parent 49ea827 commit 7c679b8

3 files changed

Lines changed: 51 additions & 23 deletions

File tree

Dockerfile

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,6 @@ COPY --link --from=builder /usr/local/etc/php/conf.d/ /usr/local/etc/php/conf.d/
155155
# Copy custom PHP settings
156156
COPY --link ./php.ini "${PHP_INI_DIR}/conf.d/99-docker.ini"
157157

158-
ENTRYPOINT ["docker-php-entrypoint"]
159-
160-
VOLUME /var/run/php
161-
VOLUME /app
162-
EXPOSE 9000/tcp
163-
164158
FROM base AS dev
165159
ARG user="php"
166160
ARG uid="900"
@@ -206,6 +200,12 @@ ONBUILD ARG user="php"
206200
ONBUILD ARG uid="900"
207201
USER "${uid}:${uid}"
208202

203+
ENTRYPOINT ["docker-php-entrypoint"]
204+
205+
VOLUME /var/run/php
206+
VOLUME /app
207+
EXPOSE 9000/tcp
208+
209209
FROM base AS prod-pre
210210
RUN <<EOF
211211
# region Remove Build Dependencies
@@ -261,3 +261,9 @@ WORKDIR "/app"
261261
ONBUILD ARG user="php"
262262
ONBUILD ARG uid="900"
263263
USER "${uid}:${uid}"
264+
265+
ENTRYPOINT ["docker-php-entrypoint"]
266+
267+
VOLUME /var/run/php
268+
VOLUME /app
269+
EXPOSE 9000/tcp

alpine.Dockerfile

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,12 +175,6 @@ EOF
175175
# Copy custom PHP settings
176176
COPY --link ./php.ini "${PHP_INI_DIR}/conf.d/99-docker.ini"
177177

178-
ENTRYPOINT ["docker-php-entrypoint"]
179-
180-
VOLUME /var/run/php
181-
VOLUME /app
182-
EXPOSE 9000/tcp
183-
184178
FROM base AS dev
185179
ARG user="php"
186180
ARG uid="900"
@@ -234,6 +228,12 @@ ONBUILD ARG user="php"
234228
ONBUILD ARG uid="900"
235229
USER "${uid}:${uid}"
236230

231+
ENTRYPOINT ["docker-php-entrypoint"]
232+
233+
VOLUME /var/run/php
234+
VOLUME /app
235+
EXPOSE 9000/tcp
236+
237237
FROM base AS prod-pre
238238
RUN <<EOF
239239
# region Remove Build Dependencies
@@ -278,3 +278,9 @@ WORKDIR "/app"
278278
ONBUILD ARG user="php"
279279
ONBUILD ARG uid="900"
280280
USER "${uid}:${uid}"
281+
282+
ENTRYPOINT ["docker-php-entrypoint"]
283+
284+
VOLUME /var/run/php
285+
VOLUME /app
286+
EXPOSE 9000/tcp

frankenphp.Dockerfile

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
2525
unzip \
2626
file \
2727
;
28+
rm -rf /var/lib/apt/lists/*
2829
EOF
2930

3031
FROM upstream AS builder
@@ -53,6 +54,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
5354
libpq-dev \
5455
git \
5556
;
57+
rm -rf /var/lib/apt/lists/*
5658
# endregion
5759

5860
docker-php-source extract
@@ -148,22 +150,14 @@ COPY --link --from=builder /usr/local/etc/php/conf.d/ /usr/local/etc/php/conf.d/
148150
COPY --link ./php.ini "${PHP_INI_DIR}/conf.d/99-docker.ini"
149151
COPY --link ./Caddyfile /etc/caddy/Caddyfile
150152

151-
CMD ["--config", "/etc/caddy/Caddyfile", "--adapter", "caddyfile"]
152-
HEALTHCHECK --interval=30s --timeout=5s --start-period=5s --retries=3 \
153-
CMD [ "curl", "-ISsfo", "/dev/null", "http://localhost:2019/metrics" ]
154-
155-
VOLUME /app
156-
EXPOSE 80/tcp
157-
EXPOSE 443/tcp
158-
EXPOSE 443/udp
159-
EXPOSE 2019/tcp
160-
EXPOSE 2019/udp
161-
162153
FROM base AS dev
163154
ARG user="php"
164155
ARG uid="900"
165156
ENV COMPOSER_ALLOW_SUPERUSER="1"
166157
ENV PHP_OPCACHE_VALIDATE_TIMESTAMPS="1"
158+
ENV XDG_DATA_HOME="/data"
159+
ENV XDG_CONFIG_HOME="/config"
160+
ENV GODEBUG="cgocheck=0"
167161

168162
# Enables PHPStorm to apply the correct path mapping on Xdebug breakpoints
169163
ENV PHP_IDE_CONFIG="serverName=Docker"
@@ -204,6 +198,14 @@ ONBUILD ARG user="php"
204198
ONBUILD ARG uid="900"
205199
USER "${uid}:${uid}"
206200

201+
ENTRYPOINT ["docker-php-entrypoint"]
202+
CMD ["--config", "/etc/caddy/Caddyfile", "--adapter", "caddyfile"]
203+
HEALTHCHECK NONE
204+
205+
VOLUME /app
206+
EXPOSE 80/tcp
207+
EXPOSE 2019/tcp
208+
207209
FROM base AS prod-pre
208210
RUN <<EOF
209211
# region Remove Build Dependencies
@@ -250,6 +252,9 @@ ENV PHP_OPCACHE_VALIDATE_TIMESTAMPS="0"
250252
ENV PHP_OPCACHE_MAX_ACCELERATED_FILES="10000"
251253
ENV PHP_OPCACHE_MEMORY_CONSUMPTION="192"
252254
ENV PHP_OPCACHE_MAX_WASTED_PERCENTAGE="10"
255+
ENV XDG_DATA_HOME="/data"
256+
ENV XDG_CONFIG_HOME="/config"
257+
ENV GODEBUG="cgocheck=0"
253258

254259
COPY --link --from=prod-pre / /
255260
RUN ln -sf "${PHP_INI_DIR}/php.ini-production" "${PHP_INI_DIR}/php.ini"
@@ -259,3 +264,14 @@ WORKDIR "/app"
259264
ONBUILD ARG user="php"
260265
ONBUILD ARG uid="900"
261266
USER "${uid}:${uid}"
267+
268+
ENTRYPOINT ["docker-php-entrypoint"]
269+
CMD ["--config", "/etc/caddy/Caddyfile", "--adapter", "caddyfile"]
270+
HEALTHCHECK --interval=30s --timeout=5s --start-period=5s --retries=3 \
271+
CMD [ "curl", "-ISsfo", "/dev/null", "http://localhost:2019/metrics" ]
272+
273+
VOLUME /app
274+
EXPOSE 80/tcp
275+
EXPOSE 443/tcp
276+
EXPOSE 443/udp
277+
EXPOSE 2019/tcp

0 commit comments

Comments
 (0)