Pedantic errors

Author: rijnb

CMakeLists.txt

@@ -27,7 +27,7 @@ project(mapcode_cpp)
 # NO_FAST_ENCODE        - Drop fast encoding support - only for internal use.
 
 set(MAPCODE_OPTIONS "")
-set(MAPCODE_WARNING_OPTIONS "-Wall -Werror")
+set(MAPCODE_WARNING_OPTIONS "-Wall -Werror -Wextra -Wpedantic")
 set(MAPCODE_SANITIZER_COMPILER_OPTIONS "-fsanitize=address -fno-common -fno-optimize-sibling-calls -fno-omit-frame-pointer")
 set(MAPCODE_SANITIZER_LINKER_OPTIONS "-fsanitize=address")
 

unittest/run_compare.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-OPTS="-Wall -Werror -Wno-pointer-to-int-cast"
+OPTS="-Wall -Werror -Wextra -Wpedantic -Wno-pointer-to-int-cast"
 
 NEW=../utility/mapcode
 OLD=$HOME/bin/mapcode-2.3.1

unittest/run_gcov.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-OPTS="-Wall -Werror -Wno-pointer-to-int-cast -fprofile-arcs -ftest-coverage"
+OPTS="-Wall -Werror -Wextra -Wpedantic -Wno-pointer-to-int-cast -fprofile-arcs -ftest-coverage"
 LIB="../mapcodelib/mapcoder.o"
 
 TEST=`which gcov`

unittest/run_gprof.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-OPTS="-Wall -Werror -Wno-pointer-to-int-cast"
+OPTS="-Wall -Werror -Wextra -Wpedantic -Wno-pointer-to-int-cast"
 LIB="../mapcodelib/mapcoder.o"
 
 TEST=`which gprof`

unittest/run_normal.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-OPTS="-Wall -Werror -Wno-pointer-to-int-cast"
+OPTS="-Wall -Werror -Wextra -Wpedantic -Wno-pointer-to-int-cast"
 
 echo "!! -------------------------------------------------------------"
 echo "Run normal..."

unittest/run_sanitizer.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-OPTS="-Wall -Werror -Wno-pointer-to-int-cast"
+OPTS="-Wall -Werror -Wextra -Wpedantic -Wno-pointer-to-int-cast"
 LIB="../mapcodelib/mapcoder.o"
 
 export ASAN_OPTIONS=debug=true:strict_string_checks=1:detect_stack_use_after_return=true:detect_invalid_pointer_pairs=99999:detect_container_overflow=true:detect_odr_violation=2:check_initialization_order=true:strict_init_order=true

unittest/run_valgrind.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-OPTS="-Wall -Werror -Wno-pointer-to-int-cast"
+OPTS="-Wall -Werror -Wextra -Wpedantic -Wno-pointer-to-int-cast"
 LIB="../mapcodelib/mapcoder.o"
 
 TEST=`which valgrind`