working version 1.0#1
Closed
manascripts wants to merge 11 commits into
Closed
Conversation
…fcore_ontvar_pipeline/main.nf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates resource allocations and input schema for the pipeline to improve sample handling, process reliability, and computational efficiency. The most significant changes are the overhaul of the sample input schema, increased resource requests for several modules, and refined process retry logic. Additionally, output naming conventions and memory scaling have been adjusted for consistency and performance.
Input Schema Changes
assets/schema_input.jsonis restructured:sampleand FastQ file fields are replaced withgroup_id,sample_id,sample_type, andbam_path, making the schema compatible with BAM-based workflows and supporting case/control sample types. Required fields are updated accordingly.Resource Allocation Updates
conf/modules.confignow request higher CPU and memory resources, especially for structural variant callers (SNIFFLES,CUTESV,SEVERUS_WITH_CONTROL,SEVERUS_NO_CONTROL,JASMINESV_SAMPLE,JASMINESV_COHORT,SVDB_QUERY_SAMPLE,SVDB_QUERY_COHORT). Memory allocations now often scale withtask.attemptfor better retry handling. [1] [2] [3] [4] [5] [6] [7] [8]Process Reliability and Retry Logic
conf/base.config, and the process timeout is re-enabled.Output Naming and Metadata Consistency
group_idinstead ofsample, aligning with the new schema and improving metadata consistency. [1] [2]Memory Scaling and Miscellaneous Adjustments
task.attempt, and several intermediate steps now explicitly set resource requirements. Some process labels have time settings commented out for flexibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]