Fix desktop artifact publish path

Author: KSemenenko

.github/workflows/ci.yml

@@ -132,7 +132,7 @@ jobs:
 
       - name: Publish Desktop App
         shell: pwsh
-        run: dotnet publish ./DotPilot/DotPilot.csproj -c Release -f net10.0-desktop -o ./${{ matrix.output_path }}
+        run: dotnet publish ./DotPilot/DotPilot.csproj -c Release -f net10.0-desktop -p:GenerateDocumentationFile=true -p:NoWarn=CS1591 -o ./${{ matrix.output_path }}
 
       - name: Upload Desktop Artifact
         uses: actions/upload-artifact@v4

AGENTS.md

@@ -123,15 +123,15 @@ Skill-management rules for this `.NET` solution:
 - `format`: `dotnet format DotPilot.slnx --verify-no-changes`
 - `analyze`: `dotnet build DotPilot.slnx -warnaserror`
 - `coverage`: `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --settings DotPilot.Tests/coverlet.runsettings --collect:"XPlat Code Coverage"`
-- `publish-desktop`: `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop`
+- `publish-desktop`: `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop -p:GenerateDocumentationFile=true -p:NoWarn=CS1591`
 
 For this app:
 
 - unit tests currently use `NUnit` through the default `VSTest` runner
 - UI tests live in `DotPilot.UITests` and are a mandatory part of normal verification; the harness must provision or resolve browser-driver prerequisites automatically instead of skipping when local setup is missing
 - `format` uses `dotnet format --verify-no-changes`
 - coverage uses the `coverlet.collector` integration on `DotPilot.Tests` with the repo runsettings file to keep generated Uno artifacts out of the coverage path
-- desktop artifact validation uses `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop` and the CI workflow must upload publish outputs for macOS, Windows, and Linux
+- desktop artifact validation uses `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop -p:GenerateDocumentationFile=true -p:NoWarn=CS1591` so publish-time analyzer plumbing stays green without weakening the normal `analyze` gate, and the CI workflow must upload publish outputs for macOS, Windows, and Linux
 - `LangVersion` is pinned to `latest` at the root
 - the repo-root lowercase `.editorconfig` is the source of truth for formatting, naming, style, and analyzer severity
 - `Directory.Build.props` owns the shared analyzer and warning policy for future projects

DotPilot/AGENTS.md

@@ -32,7 +32,7 @@ Stack: `.NET 10`, `Uno Platform`, `Uno.Extensions.Navigation`, `Uno Toolkit`, de
 ## Local Commands
 
 - `build-app`: `dotnet build DotPilot/DotPilot.csproj`
-- `publish-desktop`: `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop`
+- `publish-desktop`: `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop -p:GenerateDocumentationFile=true -p:NoWarn=CS1591`
 - `run-desktop`: `dotnet run --project DotPilot/DotPilot.csproj -f net10.0-desktop`
 - `run-wasm`: `dotnet run --project DotPilot/DotPilot.csproj -f net10.0-browserwasm`
 - `test-unit`: `dotnet test DotPilot.Tests/DotPilot.Tests.csproj`

DotPilot/App.xaml.cs

@@ -1,4 +1,6 @@
 using System.Diagnostics.CodeAnalysis;
+using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
 
 namespace DotPilot;
 
@@ -81,7 +83,8 @@ protected override async void OnLaunched(LaunchActivatedEventArgs args)
                 {
 #if DEBUG
                     // DelegatingHandler will be automatically injected
-                    services.AddTransient<DelegatingHandler, DebugHttpHandler>();
+                    Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions
+                        .AddTransient<DelegatingHandler, Services.Endpoints.DebugHttpHandler>(services);
 #endif
 
                 })

DotPilot/GlobalUsings.cs

@@ -1,6 +1,2 @@
 global using DotPilot.Models;
 global using DotPilot.Presentation;
-global using DotPilot.Services.Endpoints;
-global using Microsoft.Extensions.DependencyInjection;
-global using Microsoft.Extensions.Hosting;
-global using Microsoft.Extensions.Logging;

DotPilot/Services/Endpoints/DebugHandler.cs

@@ -1,3 +1,5 @@
+using Microsoft.Extensions.Logging;
+
 namespace DotPilot.Services.Endpoints;
 
 internal sealed class DebugHttpHandler : DelegatingHandler

ci-pr-validation.plan.md

@@ -104,6 +104,7 @@ Fix the GitHub Actions CI path used by `managedcode/dotPilot` so it builds with
 - Local `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --collect:"XPlat Code Coverage"` reproduced a second blocker: coverage did not crash, but `coverlet.collector` spent minutes instrumenting generated Uno artifacts before test execution began, which was not acceptable for PR validation.
 - The workflow also lacked any desktop publish stage, so pull requests produced no downloadable app artifacts for human verification across macOS, Windows, and Linux.
 - After the first PR push, GitHub rejected the new workflow before any jobs started because `timeout-minutes` used `fromJSON(env.STEP_TIMEOUT_MINUTES)` at the job level, where the `env` context is not available during workflow validation.
+- After the first valid PR run started, the desktop artifact jobs failed during `dotnet publish` because Roslyn enforced `IDE0005` on build without `GenerateDocumentationFile=true`, while enabling that property globally also surfaced repo-wide `CS1591` documentation warnings as errors.
 
 ## Failing Tests And Checks Tracker
 
@@ -137,6 +138,12 @@ Fix the GitHub Actions CI path used by `managedcode/dotPilot` so it builds with
   Intended fix path: replace the dynamic timeout expression with literal timeout values and lint the workflow locally before pushing again.
   Status: fixed by the literal `timeout-minutes: 60` update and local `actionlint` validation.
 
+- [x] `Desktop publish on macOS and Linux: Roslyn IDE0005 failure`
+  Failure symptom: the PR workflow created the desktop artifact jobs, but the macOS and Linux publish steps failed before artifact upload.
+  Suspected cause: publish invoked code-style analysis with `IDE0005`, and the repo did not set `GenerateDocumentationFile=true`, which Roslyn now requires for that analyzer path on those runners; once that path was enabled, redundant global and file-level `using` directives in the app shell were also exposed.
+  Intended fix path: scope the publish fix to the artifact command by passing `GenerateDocumentationFile=true` and suppressing `CS1591` only for publish-time artifact generation, while keeping the normal `analyze` gate unchanged and removing the redundant `using` directives that publish surfaced.
+  Status: fixed by the scoped publish properties in `.github/workflows/ci.yml`, the documented `publish-desktop` command, and the `App.xaml.cs`/`GlobalUsings.cs` cleanup.
+
 ## Validation Notes
 
 - `dotnet format DotPilot.slnx --verify-no-changes` passed.
@@ -148,6 +155,8 @@ Fix the GitHub Actions CI path used by `managedcode/dotPilot` so it builds with
 - `dotnet test DotPilot.slnx` passed and included both the unit and UI suites.
 - `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop` passed locally on macOS and produced a publish directory under `artifacts/local-macos-publish`.
 - `actionlint .github/workflows/ci.yml` initially failed on invalid job-level `env` usage for `timeout-minutes`; after the fix it passed locally.
+- GitHub PR run `23013702026` exposed a publish-time analyzer failure on desktop artifact jobs; the final fix kept `GenerateDocumentationFile` and `CS1591` handling scoped to the publish command so the normal analyzer gate remains strict.
+- After removing redundant `using` directives surfaced by the publish path, the final local validation reran successfully with `format`, `build`, `analyze`, unit tests, coverage, UI tests, full solution tests, and the scoped `publish-desktop` command.
 - GitHub repository ruleset `Require Full CI Validation` was created in active mode and initially required `Quality`, `Unit Tests`, `Coverage`, and `UI Tests` on the default branch and `refs/heads/release/*`; it now also needs the new desktop artifact checks after the workflow is pushed and verified.
 
 ## Final Validation Skills