Feature/drag and drop timeline 1074#1096
Open
Rucha0901 wants to merge 3 commits into
Open
Conversation
|
@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Contributor
👋 Thanks for your PR, @Rucha0901!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
…eydown handlers and ARIA attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
This pull request introduces a state-of-the-art interactive Non-Linear Editing (NLE) Timeline Editor at the bottom of the video preview player, bringing high-fidelity visual desktop editing controls to Reframe.
Specifically, it implements:
[trimStart, trimEnd]range.currentTime) and allows dragging/clicking to seek/scrub through the video in real-time.role="slider"androle="button"), labels, bounds, and values.tabIndex={0}) on the interactive elements.🛠️ Technical Details & Files Changed
src/components/TimelineEditor.tsx[NEW]: Implemented absolute rulers, frames, mouse/touch drag scrubbers, collision thresholds, grid-snapping, and fully accessible ARIA / keydown event support.src/components/VideoEditor.tsx[MODIFY]: Replaced static frame strip with the newly designed timeline, and synchronized all seeking/preview states.src/components/TrimControl.tsx[MODIFY]: Removed pre-existing slider tracks from the side panel to keep the interface focused and cohesive.🧪 Verification & Testing
npx tsc --noEmitand confirmed zero type safety or syntax errors.npm run lintand confirmed zero ESLint warnings or errors (✔ No ESLint warnings or errors).npm run buildand confirmed successful static page generations and client-side bundler trace collections (✓ Compiled successfully).npx vitest runand ensured all pre-existing tests pass successfully.☑️ Checklist