Skip to content

fix(timeline): resolve duplicate trailing timestamps and key collisions on frames strip#1072

Open
trivikramkalagi91-commits wants to merge 1 commit into
magic-peach:mainfrom
trivikramkalagi91-commits:fix/duplicate-timeline-timestamps
Open

fix(timeline): resolve duplicate trailing timestamps and key collisions on frames strip#1072
trivikramkalagi91-commits wants to merge 1 commit into
magic-peach:mainfrom
trivikramkalagi91-commits:fix/duplicate-timeline-timestamps

Conversation

@trivikramkalagi91-commits
Copy link
Copy Markdown
Contributor

@trivikramkalagi91-commits trivikramkalagi91-commits commented May 24, 2026

Description
This PR resolves a systemic rounding flaw in the ThumbnailStrip component where trailing video frames output duplicate formatted timestamps (e.g., displaying 0:10 twice on an 11-second video or creating structural layout duplication).

The mathematical bounding constraints previously introduced collision states when video durations did not divide cleanly into the set interval steps. This fix introduces a string-based tracking layout using a native Set against the formatted output of formatTime(), ensuring every generated frame is strictly unique in both value and presentation.

Related Issue
Fixes #1069

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: trivikramkalagi91-commits
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screenshots:
BEFORE:
one extra frame
image
AFTER:
only 3 frames
image
image

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

@trivikramkalagi91-commits is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 24, 2026

✅ PR Format Check Passed — @trivikramkalagi91-commits

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @trivikramkalagi91-commits!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor labels May 24, 2026
@trivikramkalagi91-commits
Copy link
Copy Markdown
Contributor Author

Hi @magic-peach I've submitted this PR to resolve issue #1069. It fixes the systemic rounding flaw causing duplicate trailing timestamps on shorter video timelines. Local tests, linting, and type-checking all pass successfully. Ready for your review (and Vercel authorization).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate timestamps and frames generated on short video timelines.

1 participant