Skip to content

fix: custom ratio card alignment and dimensions layout#1071

Open
shrutisharma-sh wants to merge 1 commit into
magic-peach:mainfrom
shrutisharma-sh:fix/card-alignment
Open

fix: custom ratio card alignment and dimensions layout#1071
shrutisharma-sh wants to merge 1 commit into
magic-peach:mainfrom
shrutisharma-sh:fix/card-alignment

Conversation

@shrutisharma-sh
Copy link
Copy Markdown
Contributor

Fixes #1042

Changes

  • Added col-span-1 and items-start to preset grid to fix Custom card misalignment
  • Redesigned custom dimensions block into a 2-row layout:
    • Row 1: Width × Height inputs (flex, no overflow)
    • Row 2: Ratio pill badge (always visible, never clips outside container)

Root Cause

The Custom card was breaking grid rhythm on the last row, and the Ratio field was overflowing the sidebar panel (~27px outside bounds) because a single-row flex layout couldn't fit 3 columns in a ~273px wide container.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

@shrutisharma-sh is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @shrutisharma-sh

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design labels May 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @shrutisharma-sh!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Custom Ratio Card Misaligned in Preset Grid

1 participant