fix: defer theme initialization to prevent SSR hydration mismatch#1063
Open
Pranav-IIITM wants to merge 2 commits into
Open
fix: defer theme initialization to prevent SSR hydration mismatch#1063Pranav-IIITM wants to merge 2 commits into
Pranav-IIITM wants to merge 2 commits into
Conversation
|
@Pranav-IIITM is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Pranav-IIITMBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:intermediate
Contributor
👋 Thanks for your PR, @Pranav-IIITM!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a React hydration mismatch caused by theme state being initialized
using browser-only DOM checks (
document.documentElement.classList.contains("dark"))during SSR. The server rendered a different theme than the client, causing
hydration warnings on every page load.
Changes made:
ThemeProvider.tsx— theme state now starts asundefined; real themeis detected and applied inside
useEffect(client-only, no SSR reads)ThemeToggle.tsx— returnsnullwhiletheme === undefinedto preventflicker and hydration warnings
layout.tsx— already hadsuppressHydrationWarningon<html>, nochanges needed
Verified: Zero hydration warnings in clean incognito Chrome window.
The hydration warning visible in normal Chrome is caused by a browser
extension injecting into the DOM before React loads — not by application code.
Related Issue
Closes #1020
Type of Contribution
Participant Info
Screen Recording
Recorded in clean incognito window — zero hydration warnings on hard
refresh, theme toggle works correctly, theme persists after refresh.
No.hydration.Warning.1.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in