You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes a race condition in src/lib/ffmpeg.ts where concurrent calls to loadFFmpeg() during the async initialization window could trigger multiple
simultaneous ffmpeg.load() calls on the same WASM instance, corrupting
internal worker state.
Introduces a shared loadingPromise guard so all concurrent callers share
a single initialization flow. Failed loads reset both ffmpegInstance and loadingPromise to allow safe retries.
Just wanted to flag something — this issue (#1014) was originally labeled level:advanced by you, but it appears the bot has since
relabeled it as level:beginner .
Could you please restore the level:advanced label? The fix involves
resolving a WASM runtime race condition with a shared pending-load promise
guard, which is non-trivial and aligns with the advanced classification
you originally assigned.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in
src/lib/ffmpeg.tswhere concurrent calls toloadFFmpeg()during the async initialization window could trigger multiplesimultaneous
ffmpeg.load()calls on the same WASM instance, corruptinginternal worker state.
Introduces a shared
loadingPromiseguard so all concurrent callers sharea single initialization flow. Failed loads reset both
ffmpegInstanceandloadingPromiseto allow safe retries.Related Issue
Closes #1014
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link: N/A — no UI changes
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in