Skip to content

feat: Fix onboarding tooltip positioning, auto-skip, and measurement stability under GSSoC'26#1057

Open
janmejay1438 wants to merge 1 commit into
magic-peach:mainfrom
janmejay1438:bug/fix-onboardingTour
Open

feat: Fix onboarding tooltip positioning, auto-skip, and measurement stability under GSSoC'26#1057
janmejay1438 wants to merge 1 commit into
magic-peach:mainfrom
janmejay1438:bug/fix-onboardingTour

Conversation

@janmejay1438
Copy link
Copy Markdown

Description

Fixes onboarding tour positioning and measurement issues in OnboardingTour.tsx.

Changes made

Fixed tooltip overflowing outside the viewport on certain steps
Removed onboarding auto-skip behavior when target measurement temporarily fails
Improved target measurement stability by replacing timeout-based measurement with double requestAnimationFrame
Stabilized onboarding positioning during auto-scroll transitions
Preserved keyboard navigation and resize re-measure support

Related Issue

Closes #922

Type of Contribution

  • Bug fix
  • GSSoC contribution

Participant Info

  • GitHub username: @janmejay1438
  • Contribution level (Intermediate):

Screen Recording

Onboarding.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

@janmejay1438 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 24, 2026

✅ PR Format Check Passed — @janmejay1438

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @janmejay1438!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 24, 2026
@janmejay1438 janmejay1438 changed the title [GSSoC'26]: Fixed onboarding Tour feat: Fix onboarding tooltip positioning, auto-skip, and measurement stability under GSSoC'26 May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [GSSoC'26] : Onboarding.tsx leaving the viewport.

1 participant