# Fix: Remove stale 500MB upload hard limit and align validation with 2GB MAX_FILE_SIZE#1044
# Fix: Remove stale 500MB upload hard limit and align validation with 2GB MAX_FILE_SIZE#1044satyamtiwari-1499 wants to merge 3 commits into
Conversation
|
@satyamtiwari-1499 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Thanks for your PR, @satyamtiwari-1499!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
@magic-peach Please review the PR and let me know the merge status. If there are any issues or changes needed, I’d be happy to work on them. |
|
@satyamtiwari-1499 This is a clean, correct fix — removing the stale 500MB hard-block and relying on the shared However, CI did not run the build/lint/typecheck checks for this PR — only Please make a small push to re-trigger CI: git commit --allow-empty -m 'ci: trigger checks'
git pushOnce all checks pass, this will be ready to merge! |
|
@magic-peach I have retriggered the ci ,please have a look |
Before fix - https://github.com/user-attachments/assets/d2424185-57fc-42bc-a7ae-56488970c996
After fix - https://github.com/user-attachments/assets/30c608d6-efd0-4242-ac50-18e82b55ecce
Fixes #935
Summary
This PR removes a stale 500MB hard-block in the uploader validation logic and aligns file validation with the shared
MAX_FILE_SIZEconstant (2GB).Previously, files larger than 500MB were rejected even though the UI and shared constants already indicated support up to 2GB.
Changes Made
FileUpload.tsx500MBrejection logic with sharedMAX_FILE_SIZEWARNING_FILE_SIZEbehavior for large file warningsWhy This Fix
There was an inconsistency between:
2GB)MAX_FILE_SIZE)500MBhard limit)Because of the leftover hardcoded validation, valid uploads larger than 500MB were incorrectly rejected.
This PR resolves that mismatch by ensuring validation uses the shared 2GB limit consistently.
Testing
Before Fix
700MBAfter Fix
700MBvideoSmoke Testing
Verified large-file workflow behavior including:
to ensure processing still behaves correctly with larger files.
Branch
Notes
Checklist
MAX_FILE_SIZE