Skip to content

# Fix: Remove stale 500MB upload hard limit and align validation with 2GB MAX_FILE_SIZE#1044

Open
satyamtiwari-1499 wants to merge 3 commits into
magic-peach:mainfrom
satyamtiwari-1499:fix/upload-limit-2gb
Open

# Fix: Remove stale 500MB upload hard limit and align validation with 2GB MAX_FILE_SIZE#1044
satyamtiwari-1499 wants to merge 3 commits into
magic-peach:mainfrom
satyamtiwari-1499:fix/upload-limit-2gb

Conversation

@satyamtiwari-1499
Copy link
Copy Markdown

Before fix - https://github.com/user-attachments/assets/d2424185-57fc-42bc-a7ae-56488970c996

After fix - https://github.com/user-attachments/assets/30c608d6-efd0-4242-ac50-18e82b55ecce

Fixes #935

Summary

This PR removes a stale 500MB hard-block in the uploader validation logic and aligns file validation with the shared MAX_FILE_SIZE constant (2GB).

Previously, files larger than 500MB were rejected even though the UI and shared constants already indicated support up to 2GB.


Changes Made

  • Updated uploader validation in FileUpload.tsx
  • Replaced hardcoded 500MB rejection logic with shared MAX_FILE_SIZE
  • Retained WARNING_FILE_SIZE behavior for large file warnings
  • Preserved existing upload flow and warning UX

Why This Fix

There was an inconsistency between:

  • UI/documented upload support (2GB)
  • Shared constants (MAX_FILE_SIZE)
  • Actual validation behavior (500MB hard limit)

Because of the leftover hardcoded validation, valid uploads larger than 500MB were incorrectly rejected.

This PR resolves that mismatch by ensuring validation uses the shared 2GB limit consistently.


Testing

Before Fix

  • Upload a video around 700MB
  • App rejected upload with:
File size exceeds 500MB limit

After Fix

  • Upload the same 700MB video
  • File is accepted successfully
  • Large-file warning is shown only when applicable

Smoke Testing

Verified large-file workflow behavior including:

  • Upload
  • Trim
  • Export

to ensure processing still behaves correctly with larger files.


Branch

fix/upload-limit-2gb

Notes

  • No documentation/UI wording changes included in this PR
  • This PR only updates uploader validation behavior

Checklist

  • Remove stale 500MB hard validation
  • Use shared MAX_FILE_SIZE
  • Keep warning behavior intact
  • Test upload with files >500MB
  • Run quick smoke test on large video workflow

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

@satyamtiwari-1499 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 24, 2026

⚠️ PR Format Issues — @satyamtiwari-1499

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @satyamtiwari-1499!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:testing Testing labels May 24, 2026
@satyamtiwari-1499
Copy link
Copy Markdown
Author

@magic-peach Please review the PR and let me know the merge status. If there are any issues or changes needed, I’d be happy to work on them.

@magic-peach magic-peach added gssoc'26 GirlScript Summer of Code 2026 and removed type:docs Documentation type:design UI/UX design labels May 24, 2026
@magic-peach
Copy link
Copy Markdown
Owner

@satyamtiwari-1499 This is a clean, correct fix — removing the stale 500MB hard-block and relying on the shared MAX_FILE_SIZE constant is exactly right. The before/after screen recordings are very helpful.

However, CI did not run the build/lint/typecheck checks for this PR — only validate passed. I need all of build, lint, and typecheck to pass before merging.

Please make a small push to re-trigger CI:

git commit --allow-empty -m 'ci: trigger checks'
git push

Once all checks pass, this will be ready to merge!

@github-actions github-actions Bot added type:design UI/UX design type:docs Documentation labels May 24, 2026
@satyamtiwari-1499
Copy link
Copy Markdown
Author

@magic-peach I have retriggered the ci ,please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File upload rejects videos over 500MB despite 2GB limit being advertised

2 participants