Merge pull request #92 from mackysoft/feature/abstract-generic-field-support

Support abstract generic field and create tests

Author: mackysoft

.github/workflows/build.yaml

@@ -41,6 +41,9 @@ jobs:
       - name: Build
         uses: game-ci/unity-builder@v4
         env:
-          UNITY_LICENSE: ${{ secrets.UNITY_LICENSE_2020 }}
+          UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
+          UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
+          UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
         with:
           targetPlatform: ${{ matrix.targetPlatform }}
+          unityVersion: 2021.3.45f2

.github/workflows/package.yaml

@@ -5,7 +5,7 @@ on:
   push: { branches: [main] }
 
 env:
-  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE_2020 }}
+  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
 
 jobs:
   build:
@@ -34,7 +34,7 @@ jobs:
           UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
           UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
         with:
-          unityVersion: 2021.3.29f1
+          unityVersion: 2021.3.45f2
           buildMethod: MackySoft.PackageTools.Editor.UnityPackageExporter.Export
 
       # Upload

.github/workflows/release.yaml

@@ -65,9 +65,9 @@ jobs:
     needs: [update-packagejson]
     strategy:
       matrix:
-        unity: ["2021.3.29f1"]
+        unity: ["2021.3.45f2"]
         include:
-          - unityVersion: 2021.3.29f1
+          - unityVersion: 2021.3.45f2
             license: UNITY_LICENSE
     runs-on: ubuntu-latest
     timeout-minutes: 15

.github/workflows/tests.yaml

@@ -0,0 +1,55 @@
+name: Tests
+
+on:
+  push:
+    branches-ignore:
+      - documentation
+      - gh-pages
+  pull_request: {}
+
+jobs:
+  test:
+    name: ${{ matrix.testMode }} on Unity ${{ matrix.unityVersion }}
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        projectPath:
+          - .
+        unityVersion:
+          - 2021.3.45f2
+          - 2023.2.22f1
+        testMode:
+          - editmode
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          lfs: true
+
+      - name: Cache
+        uses: actions/cache@v4
+        with:
+          path: ${{ matrix.projectPath }}/Library
+          key: Library-${{ runner.os }}-${{ matrix.projectPath }}-${{ matrix.unityVersion }}-${{ matrix.testMode }}-${{ hashFiles('**/Packages/manifest.json', '**/Packages/packages-lock.json', '**/ProjectSettings/ProjectVersion.txt') }}
+          restore-keys: |
+            Library-${{ runner.os }}-${{ matrix.projectPath }}-${{ matrix.unityVersion }}-${{ matrix.testMode }}-
+            Library-${{ runner.os }}-${{ matrix.projectPath }}-${{ matrix.unityVersion }}-
+            Library-${{ runner.os }}-${{ matrix.projectPath }}-
+
+      - name: Tests
+        uses: game-ci/unity-test-runner@v4
+        id: tests
+        env:
+          UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
+          UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
+          UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
+        with:
+          projectPath: ${{ matrix.projectPath }}
+          unityVersion: ${{ matrix.unityVersion }}
+          testMode: ${{ matrix.testMode }}
+          artifactsPath: test-results
+          artifactsName: TestResults-${{ matrix.unityVersion }}-${{ matrix.testMode }}

AGENTS.md

@@ -0,0 +1,51 @@
+# Unity-SerializeReferenceExtensions — AGENTS.md
+
+## Project overview
+This repository provides editor tooling for Unity's [SerializeReference], including `SubclassSelector`
+to pick concrete implementations of interfaces / abstract types in the Inspector.
+
+Primary risk area: type discovery & filtering (what types appear in the selector).
+
+## Repository layout
+- Repository URL: `https://github.com/mackysoft/Unity-SerializeReferenceExtensions`
+- Package source: `Assets/MackySoft/MackySoft.SerializeReferenceExtensions`
+- Editor code: `.../Editor/**`
+- Tests: `.../Tests/**`
+
+## Unity compatibility (critical)
+- Minimum supported Unity: 2021.3 (baseline for development/testing).
+- Unity 2023.2+ has enhanced generic type support (variance, etc.). Changes must not break 2021.3 behavior and guarded by `UNITY_2023_2_OR_NEWER`.
+
+## CI (GitHub Actions)
+I use GameCI `unity-test-runner`.
+- Always run EditMode tests.
+- Run a Unity matrix that includes:
+  - 2021.3.x (minimum baseline)
+  - 2023.2+ (generic/variance feature gate)
+
+## How to run tests locally
+### EditMode
+Run Unity in batchmode:
+```
+PROJECT_ROOT="$(pwd)"
+RESULT_XML="$PROJECT_ROOT/TestResults/editmode.xml"
+
+mkdir -p "$(dirname "$RESULT_XML")"
+
+"<UNITY_EXE>" -batchmode -nographics -quit \
+  -projectPath "$PROJECT_ROOT" \
+  -runTests -testPlatform editmode \
+  -testResults "$RESULT_XML"
+```
+
+## Architecture guardrails
+- Runtime surface area should remain minimal (mainly attributes / data structures).
+- Editor implementation (PropertyDrawer/UI/type search) must stay under `Editor/`.
+- Avoid introducing UnityEditor references into Runtime assemblies.
+
+## Coding conventions
+- Prefer `UnityEditor.TypeCache` for type discovery. Avoid full AppDomain scans unless necessary.
+- Keep allocations low in IMGUI paths (e.g., `OnGUI`).
+- Keep public API stable; if changing type filtering behavior, add/adjust tests.
+- As a general rule, you should follow the restrictions on SerializeReference in Unity's official documentation.
+  - https://docs.unity3d.com/ScriptReference/SerializeReference.html

Assets/Example/Example_Generics.cs

@@ -85,6 +85,12 @@ public class Example_Generics : MonoBehaviour
 {
 
 	[SerializeReference, SubclassSelector]
+	public IContravarianceAction<INetworkActor> contravarianceAction = null;
+
+    [SerializeReference, SubclassSelector]
+	public BaseAction<IActor> baseAction = null;
+
+    [SerializeReference, SubclassSelector]
 	public List<IContravarianceAction<INetworkActor>> contravarianceActions = new List<IContravarianceAction<INetworkActor>>();
 
 	[SerializeReference, SubclassSelector]

Assets/MackySoft/MackySoft.SerializeReferenceExtensions/Editor/SubclassSelectorDrawer.cs

@@ -150,8 +150,9 @@ TypePopupCache GetTypePopup (SerializedProperty property) {
 				var state = new AdvancedDropdownState();
 
 				Type baseType = ManagedReferenceUtility.GetType(managedReferenceFieldTypename);
-				var popup = new AdvancedTypePopup(
-					TypeSearch.GetTypes(baseType),
+				var types = TypeSearchService.TypeCandiateService.GetDisplayableTypes(baseType);
+                var popup = new AdvancedTypePopup(
+                    types,
 					k_MaxTypePopupLineCount,
 					state
 				);