Summary
src/beads/memory.ts declares storeFinding() as a synchronous method returning string, but src/agents/base.ts calls it with await. While JavaScript tolerates await on non-Promises, this is misleading and will break if the implementation is ever made async (e.g., switching to async SQLite).
Locations
src/beads/memory.ts: storeFinding(finding: Finding): string
src/agents/base.ts: await this.memory.storeFinding(memoryFinding)
Recommended Fix
Make storeFinding explicitly async to match the call-site expectation and future-proof for async DB drivers:
async storeFinding(finding: Finding): Promise<string> { ... }
Backlink: #1
Summary
src/beads/memory.tsdeclaresstoreFinding()as a synchronous method returningstring, butsrc/agents/base.tscalls it withawait. While JavaScript toleratesawaiton non-Promises, this is misleading and will break if the implementation is ever made async (e.g., switching to async SQLite).Locations
src/beads/memory.ts:storeFinding(finding: Finding): stringsrc/agents/base.ts:await this.memory.storeFinding(memoryFinding)Recommended Fix
Make
storeFindingexplicitly async to match the call-site expectation and future-proof for async DB drivers:Backlink: #1