Merge pull request #4 from TomatoInOil/fix/datetime-and-null-trace-id

fix: use Z suffix for UTC timestamps and omit null trace_id

Author: Polliog

logtide_sdk/models.py

@@ -31,18 +31,22 @@ class LogEntry:
     def __post_init__(self) -> None:
         """Initialize default values."""
         if self.time is None:
-            self.time = datetime.now(timezone.utc).isoformat()
+            self.time = datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%S.%fZ")
+        elif self.time.endswith("+00:00"):
+            self.time = self.time[:-6] + "Z"
 
     def to_dict(self) -> Dict[str, Any]:
         """Convert to dictionary for JSON serialization."""
-        return {
+        result: Dict[str, Any] = {
             "service": self.service,
             "level": self.level.value,
             "message": self.message,
             "time": self.time,
             "metadata": self.metadata,
-            "trace_id": self.trace_id,
         }
+        if self.trace_id is not None:
+            result["trace_id"] = self.trace_id
+        return result
 
 
 @dataclass

tests/test_v084.py

@@ -16,7 +16,6 @@
     serialize_exception,
 )
 
-
 # ---------------------------------------------------------------------------
 # Helpers
 # ---------------------------------------------------------------------------
@@ -202,12 +201,48 @@ def test_error_method_uses_exception_key():
 # ---------------------------------------------------------------------------
 
 
-def test_log_entry_time_is_timezone_aware():
-    """LogEntry.time must include timezone offset (not naive UTC)."""
+def test_log_entry_time_uses_z_suffix():
+    """LogEntry.time must use Z suffix for UTC (required by server schema)."""
     entry = LogEntry(service="svc", level=LogLevel.INFO, message="hello")
     assert entry.time is not None
-    # timezone.utc isoformat produces '+00:00' suffix
-    assert "+00:00" in entry.time or "Z" in entry.time
+    assert entry.time.endswith("Z")
+    assert "+00:00" not in entry.time
+
+
+def test_log_entry_normalizes_offset_to_z():
+    """Caller-supplied +00:00 offset must be normalized to Z."""
+    entry = LogEntry(
+        service="svc",
+        level=LogLevel.INFO,
+        message="hello",
+        time="2026-04-05T10:00:00.123456+00:00",
+    )
+    assert entry.time == "2026-04-05T10:00:00.123456Z"
+
+
+def test_log_entry_preserves_non_utc_offset():
+    """Non-UTC offsets must be left as-is (caller's responsibility)."""
+    entry = LogEntry(
+        service="svc",
+        level=LogLevel.INFO,
+        message="hello",
+        time="2026-04-05T10:00:00+03:00",
+    )
+    assert entry.time == "2026-04-05T10:00:00+03:00"
+
+
+def test_to_dict_omits_none_trace_id():
+    """to_dict() must omit trace_id when None (server rejects null)."""
+    entry = LogEntry(service="svc", level=LogLevel.INFO, message="hello")
+    d = entry.to_dict()
+    assert "trace_id" not in d
+
+
+def test_to_dict_includes_trace_id_when_set():
+    """to_dict() must include trace_id when it has a value."""
+    entry = LogEntry(service="svc", level=LogLevel.INFO, message="hello", trace_id="abc-123")
+    d = entry.to_dict()
+    assert d["trace_id"] == "abc-123"
 
 
 # ---------------------------------------------------------------------------