minor fixes

Author: whummer

Makefile

@@ -9,10 +9,16 @@ build:           ## Build the code using Maven
 publish-maven:   ## Publish artifacts to Maven Central
 	ADDITIONAL_MVN_TARGETS=deploy ADDITIONAL_MVN_ARGS=" " make build
 
-test:            ## Run Java/JUnit tests for AWS SDK v1 and v2
+test-v1:
+	USE_SSL=1 SERVICES=serverless,kinesis,sns,sqs,iam,cloudwatch mvn -Pawssdkv1 \
+                -Dtest="!cloud.localstack.awssdkv2.*Test" test
+
+test-v2:
 	USE_SSL=1 SERVICES=serverless,kinesis,sns,sqs,iam,cloudwatch mvn -Pawssdkv2 \
 		-Dtest="cloud.localstack.awssdkv2.*Test" test
-	USE_SSL=1 SERVICES=serverless,kinesis,sns,sqs,iam,cloudwatch mvn -Pawssdkv1 \
-		-Dtest="!cloud.localstack.awssdkv2.*Test" test
 
-.PHONY: usage clean install test
+test:            ## Run Java/JUnit tests for AWS SDK v1 and v2
+	make test-v2
+	make test-v1
+
+.PHONY: usage clean install test test-v1 test-v2

README.md

@@ -83,7 +83,7 @@ different location, then use the `DOCKER_LOCATION` environment variable to speci
 
 ### Deprecated Configurations
 
-Due to recent changes in LocalStack (e.g., exposing all services via a single edge port, `4566`), the following configuration parameters are now deprecated in the latest version:
+Due to recent changes in LocalStack (exposing all services via a single edge port, `4566`), the following configuration parameters are now deprecated in the latest version:
 
 | property                    | usage                                                                                                                        | type                         | default value |
 |-----------------------------|------------------------------------------------------------------------------------------------------------------------------|------------------------------|---------------|
@@ -106,6 +106,4 @@ make build
 
 ## License
 
-Copyright (c) LocalStack maintainers and contributors.
-
-This version of LocalStack is released under the Apache License, Version 2.0 (see LICENSE.txt).
+This code is released under the Apache License, Version 2.0 (see LICENSE.txt).

src/test/java/cloud/localstack/awssdkv2/BasicFeaturesSDKV2Test.java

@@ -53,7 +53,7 @@ public void testCreateKinesisStreamV2() throws Exception {
         CreateStreamResponse response = kinesisClient.createStream(request).get();
         Assert.assertNotNull(response);
     }
-    
+
     @Test
     public void testCreateKinesisRecordV2() throws Exception {
         String streamName = "test-s-"+UUID.randomUUID().toString();
@@ -62,7 +62,7 @@ public void testCreateKinesisRecordV2() throws Exception {
             .streamName(streamName).shardCount(1).build();
         CreateStreamResponse response = kinesisClient.createStream(request).get();
         Assert.assertNotNull(response);
-        
+
         SdkBytes payload = SdkBytes.fromByteBuffer(ByteBuffer.wrap(String.format("testData-%d", 1).getBytes()));
         PutRecordRequest.Builder putRecordRequest = PutRecordRequest.builder();
         putRecordRequest.streamName(streamName);
@@ -117,7 +117,8 @@ public void testGetSsmParameter() throws Exception {
     public void testGetSecretsManagerSecret() throws Exception {
         final SecretsManagerAsyncClient clientSecretsManager = TestUtils.getClientSecretsManagerAsyncV2();
         clientSecretsManager.createSecret(CreateSecretRequest.builder().name("testsecret").secretString("secretcontent").build());
-        CompletableFuture<GetSecretValueResponse> getSecretResponse = clientSecretsManager.getSecretValue(GetSecretValueRequest.builder().secretId("testsecret").build());
+        CompletableFuture<GetSecretValueResponse> getSecretResponse = clientSecretsManager.getSecretValue(
+            GetSecretValueRequest.builder().secretId("testsecret").build());
         String secretValue = getSecretResponse.get().secretString();
 
         Assert.assertNotNull(secretValue);
@@ -128,8 +129,11 @@ public void testGetSecretsManagerSecret() throws Exception {
     public void testGetSecretAsParam() throws Exception {
         final SsmAsyncClient clientSsm = TestUtils.getClientSSMAsyncV2();
         final SecretsManagerAsyncClient clientSecretsManager = TestUtils.getClientSecretsManagerAsyncV2();
-        clientSecretsManager.createSecret(CreateSecretRequest.builder().name("testsecret").secretString("secretcontent").build());
-        CompletableFuture<GetParameterResponse> getParameterResponse = clientSsm.getParameter(GetParameterRequest.builder().name("/aws/reference/secretsmanager/testsecret").build());
+        clientSecretsManager.createSecret(CreateSecretRequest.builder()
+            .name("testsecret").secretString("secretcontent").build()).join();
+
+        CompletableFuture<GetParameterResponse> getParameterResponse = clientSsm.getParameter(
+            GetParameterRequest.builder().name("/aws/reference/secretsmanager/testsecret").build());
         String parameterValue = getParameterResponse.get().parameter().value();
 
         Assert.assertNotNull(parameterValue);