Skip to content

refactor: use module.run_command instead of subprocess #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richm merged 1 commit into from
Apr 2, 2026
+4 −3
Merged

refactor: use module.run_command instead of subprocess #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions library/network_connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
import re
import shlex
import socket
import subprocess
import time
import traceback
import logging
Expand Down Expand Up @@ -2684,7 +2683,8 @@
present and did not save any state about the corresponding interface.
"""
try:
subprocess.call(
# run_command returns rc, stdout, and stderr but we don't need them
_rc, _stdout, _stderr = self.run_env.run_command(
Comment thread Dismissed
Comment thread Dismissed
Comment thread Dismissed
[
"busctl",
"--system",
Expand All @@ -2696,7 +2696,8 @@
"as",
"1",
path,
]
],
handle_exceptions=False,
)
except Exception:
pass
Expand Down
Loading