Add interfaces settings GET

Author: lgarber-akamai

linode_api4/objects/linode.py

@@ -707,7 +707,6 @@ class Instance(Base):
         "disk_encryption": Property(),
         "lke_cluster_id": Property(),
         "capabilities": Property(unordered=True),
-        "interfaces_settings": Property(relationship=LinodeInterfacesSettings),
     }
 
     @property
@@ -1903,6 +1902,25 @@ def interface_create(
 
         return LinodeInterface(self._client, result["id"], self.id, json=result)
 
+    @property
+    def interfaces_settings(self):
+        # NOTE: We do not implement this as a Property because Property does
+        # not currently have a mechanism for 1:1 sub-entities.
+        result = self._client.get(
+            "{}/interfaces/settings".format(Instance.api_endpoint), model=self
+        )
+
+        if not "network_helper" in result:
+            raise UnexpectedResponseError(
+                "Unexpected response when getting settings for Linode interfaces!",
+                json=result,
+            )
+
+        # TODO (Enhanced Interfaces): Error handling for Linodes using legacy interfaces?
+
+        s = LinodeInterfacesSettings(self._client, self.id, result)
+        return s
+
     @property
     def interfaces(self):
         if not hasattr(self, "_interfaces"):

linode_api4/objects/linode_interfaces.py

@@ -24,10 +24,10 @@ class LinodeInterfacesSettingsDefaultRoute(JSONObject):
 
 
 class LinodeInterfacesSettings(Base):
-    api_endpoint = "/linode/instances/{linode_id}/interfaces/settings"
+    api_endpoint = "/linode/instances/{id}/interfaces/settings"
 
     properties = {
-        "linode_id": Property(identifier=True),
+        "id": Property(identifier=True),
         "network_helper": Property(mutable=True),
         "default_route": Property(
             mutable=True, json_object=LinodeInterfacesSettingsDefaultRoute

test/fixtures/linode_instances_124_interfaces_settings.json

@@ -2,13 +2,13 @@
   "network_helper": true,
   "default_route": {
     "ipv4_interface_id": 123,
-    "ipv4_eligable_interface_ids": [
+    "ipv4_eligible_interface_ids": [
       123,
       456,
       789
     ],
     "ipv6_interface_id": 456,
-    "ipv6_eligable_interface_ids": [
+    "ipv6_eligible_interface_ids": [
       123,
       456
     ]

test/unit/objects/linode_interface_test.py

@@ -119,3 +119,5 @@ def test_get_vlan(self):
         self.assert_linode_124_interface_789(iface)
         iface.invalidate()
         self.assert_linode_124_interface_789(iface)
+
+    # TODO (Enhanced Interfaces): iface update tests

test/unit/objects/linode_test.py

@@ -485,6 +485,26 @@ def test_get_interfaces(self):
             next(iface for iface in interfaces if iface.id == 789)
         )
 
+    def test_get_interfaces_settings(self):
+        instance = Instance(self.client, 124)
+
+        iface_settings = instance.interfaces_settings
+
+        assert iface_settings.network_helper
+
+        assert iface_settings.default_route.ipv4_interface_id == 123
+        assert iface_settings.default_route.ipv4_eligible_interface_ids == [
+            123,
+            456,
+            789,
+        ]
+
+        assert iface_settings.default_route.ipv6_interface_id == 456
+        assert iface_settings.default_route.ipv6_eligible_interface_ids == [
+            123,
+            456,
+        ]
+
 
 class DiskTest(ClientBaseCase):
     """