Basic integration test

Author: lgarber-akamai

linode_api4/objects/linode_interfaces.py

@@ -163,6 +163,12 @@ class LinodeInterfaceOptions(JSONObject):
     Options accepted when creating or updating a Linode Interface.
     """
 
+    always_include = {
+        # If a default firewall_id isn't configured, the API requires that
+        # firewall_id is defined in the LinodeInterface POST body.
+        "firewall_id"
+    }
+
     firewall_id: Optional[Union[Firewall, int]] = None
     default_route: Optional[LinodeInterfaceDefaultRouteOptions] = None
     vpc: Optional[LinodeInterfaceVPCOptions] = None

test/integration/models/linode/interfaces/test_interfaces.py

@@ -1,4 +1,4 @@
-from test.integration.conftest import get_region
+import ipaddress
 from test.integration.helpers import get_test_label
 
 import pytest
@@ -10,6 +10,7 @@
     LinodeInterfaceDefaultRouteOptions,
     LinodeInterfaceOptions,
     LinodeInterfacePublicOptions,
+    LinodeInterfaceVLANOptions,
     LinodeInterfaceVPCOptions,
 )
 
@@ -21,11 +22,8 @@ def linode_create_with_interfaces(
     client = test_linode_client
     vpc, subnet = create_vpc_with_subnet
 
-    region = get_region(
-        client,
-        {"Linodes", "Cloud Firewall", "Linode Interfaces"},
-        site_type="core",
-    )
+    # Are there regions where VPCs are supported but Linode Interfaces aren't
+    region = vpc.region
     label = get_test_label()
 
     instance, _ = client.linode.instance_create(
@@ -44,14 +42,15 @@ def linode_create_with_interfaces(
                 public=LinodeInterfacePublicOptions(),
             ),
             LinodeInterfaceOptions(
-                firewall_id=e2e_test_firewall.id,
-                default_route=LinodeInterfaceDefaultRouteOptions(
-                    ipv4=True,
-                ),
                 vpc=LinodeInterfaceVPCOptions(
                     subnet_id=subnet.id,
                 ),
             ),
+            LinodeInterfaceOptions(
+                vlan=LinodeInterfaceVLANOptions(
+                    vlan_label="test-vlan", ipam_address="10.0.0.5/32"
+                ),
+            ),
         ],
     )
 
@@ -60,8 +59,12 @@ def linode_create_with_interfaces(
     instance.delete()
 
 
-def test_linode_create_with_linode_interfaces(linode_create_with_interfaces):
+def test_linode_create_with_linode_interfaces(
+    create_vpc_with_subnet,
+    linode_create_with_interfaces,
+):
     instance: Instance = linode_create_with_interfaces
+    vpc, subnet = create_vpc_with_subnet
 
     def __assert_base(iface: LinodeInterface):
         assert iface.id is not None
@@ -88,8 +91,38 @@ def __assert_public(iface: LinodeInterface):
         assert len(iface.public.ipv6.shared) == 0
         assert len(iface.public.ipv6.ranges) == 0
 
+    def __assert_vpc(iface: LinodeInterface):
+        __assert_base(iface)
+
+        assert not iface.default_route.ipv4
+        assert not iface.default_route.ipv6
+
+        assert iface.vpc.vpc_id == vpc.id
+        assert iface.vpc.subnet_id == subnet.id
+
+        assert ipaddress.ip_address(
+            iface.vpc.ipv4.addresses[0].address
+        ) in ipaddress.ip_network(subnet.ipv4)
+        assert iface.vpc.ipv4.addresses[0].primary
+        assert iface.vpc.ipv4.addresses[0].nat_1_1_address is None
+
+        assert len(iface.vpc.ipv4.ranges) == 0
+
+    def __assert_vlan(iface: LinodeInterface):
+        __assert_base(iface)
+
+        assert not iface.default_route.ipv4
+        assert not iface.default_route.ipv6
+
+        assert iface.vlan.vlan_label == "test-vlan"
+        assert iface.vlan.ipam_address == "10.0.0.5/32"
+
     __assert_public(instance.interfaces[0])
+    __assert_vpc(instance.interfaces[1])
+    __assert_vlan(instance.interfaces[2])
 
     instance.invalidate()
 
     __assert_public(instance.interfaces[0])
+    __assert_vpc(instance.interfaces[1])
+    __assert_vlan(instance.interfaces[2])