Apply code review sugestions

Author: psnoch-akamai

test/integration/models/sharegroups/test_sharegroups.py

@@ -19,7 +19,7 @@
 
 
 def wait_for_image_status(
-    test_linode_client, image_id, expected_status, timeout=180, interval=5
+        test_linode_client, image_id, expected_status, timeout=360, interval=5
 ):
     import time
 
@@ -73,15 +73,17 @@ def share_group_id(test_linode_client):
     group.delete()
 
 
-def test_get_share_groups(test_linode_client):
+def test_get_share_groups(
+        test_linode_client, share_group_id
+):
     response = test_linode_client.sharegroups()
     sharegroups_list = response.lists[0]
     assert len(sharegroups_list) > 0
     assert sharegroups_list[0].api_endpoint == "/images/sharegroups/{id}"
     assert sharegroups_list[0].id > 0
     assert sharegroups_list[0].description != ""
     assert isinstance(sharegroups_list[0].images_count, int)
-    assert sharegroups_list[0].is_suspended == False
+    assert not sharegroups_list[0].is_suspended
     assert sharegroups_list[0].label != ""
     assert isinstance(sharegroups_list[0].members_count, int)
     assert sharegroups_list[0].uuid != ""
@@ -100,7 +102,7 @@ def test_add_update_remove_share_group(test_linode_client):
     assert share_group.id > 0
     assert share_group.description == "Test api4python create"
     assert isinstance(share_group.images_count, int)
-    assert share_group.is_suspended == False
+    assert not share_group.is_suspended
     assert share_group.label == group_label
     assert isinstance(share_group.members_count, int)
     assert share_group.uuid != ""
@@ -121,7 +123,7 @@ def test_add_update_remove_share_group(test_linode_client):
     assert load_share_group_after_update.id == share_group.id
     assert load_share_group_after_update.label == "Updated Sharegroup Label"
     assert (
-        load_share_group_after_update.description == "Test update description"
+            load_share_group_after_update.description == "Test update description"
     )
 
     share_group.delete()
@@ -131,7 +133,7 @@ def test_add_update_remove_share_group(test_linode_client):
 
 
 def test_add_get_update_revoke_image_to_share_group(
-    test_linode_client, create_image_id, share_group_id
+        test_linode_client, create_image_id, share_group_id
 ):
     share_group = test_linode_client.load(ImageShareGroup, share_group_id)
     add_image_response = share_group.add_images(
@@ -143,22 +145,22 @@ def test_add_get_update_revoke_image_to_share_group(
     )
     assert 0 < len(add_image_response)
     assert (
-        add_image_response[0].image_sharing.shared_by.sharegroup_id
-        == share_group.id
+            add_image_response[0].image_sharing.shared_by.sharegroup_id
+            == share_group.id
     )
     assert (
-        add_image_response[0].image_sharing.shared_by.source_image_id
-        == create_image_id
+            add_image_response[0].image_sharing.shared_by.source_image_id
+            == create_image_id
     )
 
     get_response = share_group.get_image_shares()
     assert 0 < len(get_response)
     assert (
-        get_response[0].image_sharing.shared_by.sharegroup_id == share_group.id
+            get_response[0].image_sharing.shared_by.sharegroup_id == share_group.id
     )
     assert (
-        get_response[0].image_sharing.shared_by.source_image_id
-        == create_image_id
+            get_response[0].image_sharing.shared_by.source_image_id
+            == create_image_id
     )
     assert get_response[0].description == ""
 
@@ -174,6 +176,7 @@ def test_add_get_update_revoke_image_to_share_group(
     )
     assert 0 < len(share_groups_by_image_id_response.lists)
     assert share_groups_by_image_id_response.lists[0][0].id == share_group.id
+    assert share_groups_by_image_id_response.lists[0][0].id == "Description update"
 
     share_group.revoke_image_share(get_response[0].id)
     get_after_revoke_response = share_group.get_image_shares()
@@ -217,7 +220,7 @@ def test_try_to_add_member_invalid_token(test_linode_client, share_group_id):
     with pytest.raises(RuntimeError) as err:
         share_group.add_member(
             ImageShareGroupMemberToAdd(
-                token="notExistingToken",
+                token="not_existing_token",
                 label="New Member",
             )
         )
@@ -231,22 +234,22 @@ def test_list_share_group_members(test_linode_client, share_group_id):
 
 
 def test_try_to_get_update_revoke_share_group_member_by_invalid_token(
-    test_linode_client, share_group_id
+        test_linode_client, share_group_id
 ):
     share_group = test_linode_client.load(ImageShareGroup, share_group_id)
     with pytest.raises(RuntimeError) as err:
-        share_group.get_member("notExistingToken")
+        share_group.get_member("not_existing_token")
     assert "[404] Not found" in str(err.value)
 
     with pytest.raises(RuntimeError) as err:
         share_group.update_member(
             ImageShareGroupMemberToUpdate(
-                token_uuid="notExistingToken",
+                token_uuid="not_existing_token",
                 label="Update Member",
             )
         )
     assert "[404] Not found" in str(err.value)
 
     with pytest.raises(RuntimeError) as err:
-        share_group.remove_member("notExistingToken")
+        share_group.remove_member("not_existing_token")
     assert "[404] Not found" in str(err.value)