CEF 146: fix CanSendCookie/CanSaveCookie and cookie API issues

- Wire GetResourceRequestHandler in RequestHandler to return a
  ResourceRequestHandler (new file) that exposes GetCookieAccessFilter,
  restoring CanSendCookie/CanSaveCookie callbacks broken since CEF 146
  moved them out of CefRequestHandler into CefCookieAccessFilter
- Add #pragma once to cookie_access_filter.h to prevent C2011 redefinition
  when included from both request_handler.h and resource_request_handler.h
- Fix Cookie.SetDomain() to accept leading-dot domains (.example.com) by
  stripping the dot before IDNA validation while preserving the original
  value stored in the cookie (RFC 2109 subdomain-matching convention)
- Update setcookie.py: replace dead html-kit.com URL with google.com,
  set cookie in OnLoadEnd and verify with VisitUrlCookies

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: linesight

examples/snippets/setcookie.py

@@ -6,28 +6,56 @@
 import datetime
 
 
+class LoadHandler(object):
+    def OnLoadEnd(self, browser, frame, http_code, **_):
+        if not frame.IsMain():
+            return
+        manager = cef.CookieManager.GetGlobalManager()
+        cookie = cef.Cookie()
+        cookie.Set({
+            "name": "my_cookie",
+            "value": "my_value",
+            # Make sure domain is a valid value otherwise it crashes
+            # app (Issue #459)
+            "domain": ".google.com",
+            "path": "/",
+            "secure": True,
+            "httpOnly": False,
+            "creation": datetime.datetime(2018, 8, 22),
+            "lastAccess": datetime.datetime(2018, 8, 22),
+            "hasExpires": True,
+            "expires": datetime.datetime(2028, 12, 31, 23, 59, 59),
+        })
+        manager.SetCookie("https://www.google.com/", cookie)
+        print("Cookie set: my_cookie=my_value")
+
+        # Delay so SetCookie (async on IO thread) completes before visiting
+        cef.PostDelayedTask(cef.TID_UI, 200, visit_cookies)
+
+
+def visit_cookies():
+    manager = cef.CookieManager.GetGlobalManager()
+    manager.VisitUrlCookies(
+        "https://www.google.com/",
+        False,
+        CookieVisitor())
+
+
+class CookieVisitor(object):
+    def Visit(self, cookie, count, total, delete_cookie_out):
+        print("Cookie[%d/%d]: %s=%s (domain=%s)" % (
+            count + 1, total,
+            cookie.Get("name"), cookie.Get("value"),
+            cookie.Get("domain")))
+        return True  # continue visiting
+
+
 def main():
     cef.Initialize()
-    cef.CreateBrowserSync(
-        url="http://www.html-kit.com/tools/cookietester/",
+    browser = cef.CreateBrowserSync(
+        url="https://www.google.com/",
         window_title="Set a cookie")
-    manager = cef.CookieManager.GetGlobalManager()
-    cookie = cef.Cookie()
-    cookie.Set({
-        "name": "my_cookie",
-        "value": "my_value",
-        # Make sure domain is a valid value otherwise it crashes
-        # app (Issue #459)
-        "domain": "www.html-kit.com",
-        "path": "/",
-        "secure": False,
-        "httpOnly": False,
-        "creation": datetime.datetime(2018, 8, 22),
-        "lastAccess": datetime.datetime(2018, 8, 22),
-        "hasExpires": True,
-        "expires": datetime.datetime(2028, 12, 31, 23, 59, 59),
-    })
-    manager.SetCookie("http://www.html-kit.com/", cookie)
+    browser.SetClientHandler(LoadHandler())
     cef.MessageLoop()
     cef.Shutdown()
 

src/client_handler/cookie_access_filter.h

@@ -2,6 +2,7 @@
 // All rights reserved. Licensed under BSD 3-clause license.
 // Project website: https://github.com/cztomczak/cefpython
 
+#pragma once
 #include "common/cefpython_public_api.h"
 #include "include/cef_resource_request_handler.h"
 

src/client_handler/request_handler.cpp

@@ -7,6 +7,18 @@
 #include "include/base/cef_callback.h"
 
 
+CefRefPtr<CefResourceRequestHandler> RequestHandler::GetResourceRequestHandler(
+        CefRefPtr<CefBrowser> browser,
+        CefRefPtr<CefFrame> frame,
+        CefRefPtr<CefRequest> request,
+        bool is_navigation,
+        bool is_download,
+        const CefString& request_initiator,
+        bool& disable_default_handling) {
+    return new ResourceRequestHandler();
+}
+
+
 bool RequestHandler::OnBeforeBrowse(CefRefPtr<CefBrowser> browser,
                                     CefRefPtr<CefFrame> frame,
                                     CefRefPtr<CefRequest> request,

src/client_handler/request_handler.h

@@ -6,6 +6,7 @@
 #include "include/cef_request_handler.h"
 #include "include/base/cef_callback.h"
 #include "cookie_access_filter.h"
+#include "resource_request_handler.h"
 
 typedef cef_return_value_t ReturnValue;
 
@@ -17,6 +18,15 @@ class RequestHandler : public CefRequestHandler,
     RequestHandler(){}
     virtual ~RequestHandler(){}
 
+    CefRefPtr<CefResourceRequestHandler> GetResourceRequestHandler(
+                        CefRefPtr<CefBrowser> browser,
+                        CefRefPtr<CefFrame> frame,
+                        CefRefPtr<CefRequest> request,
+                        bool is_navigation,
+                        bool is_download,
+                        const CefString& request_initiator,
+                        bool& disable_default_handling) override;
+
     bool OnBeforeBrowse(CefRefPtr<CefBrowser> browser,
                         CefRefPtr<CefFrame> frame,
                         CefRefPtr<CefRequest> request,

src/client_handler/resource_request_handler.h

@@ -0,0 +1,26 @@
+// Copyright (c) 2012 CEF Python, see the Authors file.
+// All rights reserved. Licensed under BSD 3-clause license.
+// Project website: https://github.com/cztomczak/cefpython
+
+#pragma once
+#include "include/cef_resource_request_handler.h"
+#include "cookie_access_filter.h"
+
+// Minimal CefResourceRequestHandler that returns a CookieAccessFilter.
+// CEF 146 moved CanSendCookie/CanSaveCookie out of CefRequestHandler into
+// CefCookieAccessFilter, reachable only via this intermediate interface.
+class ResourceRequestHandler : public CefResourceRequestHandler {
+public:
+    ResourceRequestHandler() {}
+    virtual ~ResourceRequestHandler() {}
+
+    CefRefPtr<CefCookieAccessFilter> GetCookieAccessFilter(
+            CefRefPtr<CefBrowser> browser,
+            CefRefPtr<CefFrame> frame,
+            CefRefPtr<CefRequest> request) override {
+        return new CookieAccessFilter();
+    }
+
+private:
+    IMPLEMENT_REFCOUNTING(ResourceRequestHandler);
+};

src/cookie.pyx

@@ -125,8 +125,11 @@ cdef class Cookie:
             assert isinstance(domain, bytes), "domain type is not bytes"
             domain = domain.decode(g_applicationSettings["string_encoding"],
                                    errors=BYTES_DECODE_ERRORS)
+        # Strip leading dot before validation; RFC 2109 allows .example.com to
+        # mean "all subdomains", but IDNA encoding rejects empty labels.
+        validate_domain = domain.lstrip(".")
         try:
-            if not pattern.match(domain.encode("idna").decode("ascii")):
+            if not pattern.match(validate_domain.encode("idna").decode("ascii")):
                 raise Exception("Cookie.SetDomain() failed, invalid domain: {0}"
                                 .format(domain))
         except UnicodeError: