Skip to content

Commit 0dff81a

Browse files
linesightclaude
andcommitted
Fix CEF_API_HASH_PLATFORM missing from cef_version_macarm64.h
cmake_prepare_pyx.py reads CEF_API_HASH_PLATFORM and CEF_API_HASH_UNIVERSAL from the platform version header. The standard cef_version.h shipped with the CEF binary distribution does not contain these fields — they live in cef_api_versions.h under an OS_MAC platform guard. Fix: hard-code the correct macOS experimental-API hash (CEF_API_VERSION 999999) sourced from cef_api_versions.h in the Windows binary (OS_MAC guard: 6fc5fada42e6b3e5b09a3a40f66da555cdbd8d5e). Both Intel and ARM64 macOS share this value as CEF uses a single OS_MAC define. Also remove the "Update version header from downloaded CEF" CI step that copied the stripped cef_version.h (no API hash) over our crafted header, causing the KeyError at build time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 3a7e09d commit 0dff81a

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

.github/workflows/ci-macos.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ jobs:
5656
- name: Download CEF binaries
5757
run: python tools/download_cef.py
5858

59-
- name: Update version header from downloaded CEF
60-
run: |
61-
cef_dir=$(ls -d build/cef_binary_*_macosarm64 2>/dev/null | head -1)
62-
cp "$cef_dir/include/cef_version.h" src/version/cef_version_macarm64.h
63-
6459
- name: Prepare prebuilt CEF
6560
run: python tools/automate.py --prebuilt-cef
6661

src/version/cef_version_macarm64.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,11 @@
5050

5151
#define CEF_SANDBOX_COMPAT_HASH "06ced0d54abb1a72"
5252

53-
// API hashes for macOS ARM64 (CEF_API_VERSION 999999).
54-
// These are overwritten by the CI from the downloaded CEF package headers.
55-
#define CEF_API_HASH_PLATFORM "95e5118d3fc65ae6c2645b6f381947d38586e669"
56-
#define CEF_API_HASH_UNIVERSAL "95e5118d3fc65ae6c2645b6f381947d38586e669"
53+
// Experimental API hash for macOS (CEF_API_VERSION 999999).
54+
// Used by the cefpython build tools; sourced from cef_api_versions.h
55+
// (OS_MAC platform guard) in the CEF binary distribution.
56+
#define CEF_API_HASH_PLATFORM "6fc5fada42e6b3e5b09a3a40f66da555cdbd8d5e"
57+
#define CEF_API_HASH_UNIVERSAL "6fc5fada42e6b3e5b09a3a40f66da555cdbd8d5e"
5758

5859
#define DO_MAKE_STRING(p) #p
5960
#define MAKE_STRING(p) DO_MAKE_STRING(p)

0 commit comments

Comments
 (0)