-
Notifications
You must be signed in to change notification settings - Fork 285
Description
🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:
- Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
- Confirm that you’ve read the guidelines in your comment.
Overview
Complexity: Medium
Context
Create an account page
The Change
Remove Vuetify from the Create an account page by:
- Replace
ImmersiveModalLayoutwithStudioImmersiveModal - Replace
VLayoutwith custom styles - Replace
VFormwith<form>and usegenerateFormMixinfor validation - Replace
BannerwithStudioBanner - Use
KTextboxfor first and last name input - Create new components
StudioEmailFieldandStudioPasswordField- Parallels to
EmailFieldandPasswordFieldbut useKTextboxinstead ofVTextField - Use them instead of
EmailFieldandPasswordField
- Parallels to
- Use
KCheckbox,KTransition, andKTextboxfor "How do you plan on using Kolibri Studio" section - Use
KSelect,KTransitionandKTextboxfor "How did you hear about us?" section - Use
KCheckbox,KTransition, andKRouterLinkfor "I have read..." agreement section
Do not refactor "Where do you plan to use Kolibri Studio?" section (we don't yet have a replacement for Vuetify's multi-select).
Ensure that all interactions are functional as before. Do not modify ImmersiveModalLayout, Banner, TextField, TextArea, EmailField, PasswordField, CountryField, DropdownWrapper, Checkbox, and ActionLink files. Do not refactor any other areas of the codebase.
How to Get There
- Navigate to
/accounts/#/createURL - Submit the form with missing or invalid data
- Submit the form with correct data
- In browser dev tools, turn on offline throttling
Out of Scope
- Do not modify
ImmersiveModalLayout,Banner,TextField,TextArea,EmailField,PasswordField,CountryField,DropdownWrapper,Checkbox, andActionLinkfiles - Do not refactor "Where do you plan to use Kolibri Studio?" section
- Do not refactor any other areas of the codebase
Expected UI/UX changes
- Error banner text will be dark red instead of black
- Minor visual differences naturally stemming from the use of KDS
Acceptance Criteria
These are general acceptance criteria for the project. For each sub-issue, consider which are relevant.
General
- The specification above is followed.
- Except for "Expected UI/UX changes," there are no functional or visual differences in user experience.
- There are no regressions in the printing preview
- There are no
::v-deepor/deep/selectors. - All user interactions are manually tested with no regressions.
- Pull request includes screenshots.
a11y and i18n
See the project's "Guidance" for useful references.
- Implementation meets a11y standards
- All components are LTR and RTL compliant (preview with
pnpm run devserversince:hotdoesn't render RTL properly) - All user-facing strings are translated properly
- The
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. user-generated text) - Mobile experience is reasonable
Unit tests
- If there is a unit test suite already, it is meaningfully updated (even if tests don't fail)
- If there is no unit test suite, a new one is created. Do not use obsolete
@vue/test-utilsapproach. Instead, use@testing-library/vue(Vue Testing Library).
References
Sub-issue of #5060.
