Add support for channel version tokens on v1 public channel endpoint

AlexVelezLl · AlexVelezLl · commit 16109ddb9d51 · 2026-03-20T15:19:29.000-05:00
diff --git a/contentcuration/contentcuration/serializers.py b/contentcuration/contentcuration/serializers.py
@@ -22,6 +22,22 @@ def no_field_eval_repr(self):
 serializers.ModelSerializer.__repr__ = no_field_eval_repr
 
 
+def get_thumbnail_encoding(channel):
+    """
+    Historically, we did not set channel.icon_encoding in the Studio database. We
+    only set it in the exported Kolibri sqlite db. So when Kolibri asks for the channel
+    information, fall back to the channel thumbnail data if icon_encoding is not set.
+    """
+    if channel.icon_encoding:
+        return channel.icon_encoding
+    if channel.thumbnail_encoding:
+        base64 = channel.thumbnail_encoding.get("base64")
+        if base64:
+            return base64
+
+    return None
+
+
 class PublicChannelSerializer(serializers.ModelSerializer):
     """
     Called by the public API, primarily used by Kolibri. Contains information more specific to Kolibri's needs.
@@ -41,19 +57,7 @@ def match_tokens(self, channel):
         )
 
     def get_thumbnail_encoding(self, channel):
-        """
-        Historically, we did not set channel.icon_encoding in the Studio database. We
-        only set it in the exported Kolibri sqlite db. So when Kolibri asks for the channel
-        information, fall back to the channel thumbnail data if icon_encoding is not set.
-        """
-        if channel.icon_encoding:
-            return channel.icon_encoding
-        if channel.thumbnail_encoding:
-            base64 = channel.thumbnail_encoding.get("base64")
-            if base64:
-                return base64
-
-        return None
+        return get_thumbnail_encoding(channel)
 
     def generate_kind_count(self, channel):
         return channel.published_kind_count and json.loads(channel.published_kind_count)
diff --git a/contentcuration/kolibri_public/tests/test_public_v1_api.py b/contentcuration/kolibri_public/tests/test_public_v1_api.py
@@ -2,6 +2,7 @@
 from django.core.cache import cache
 from django.urls import reverse
 
+from contentcuration.models import ChannelVersion
 from contentcuration.tests.base import BaseAPITestCase
 from contentcuration.tests.testdata import generated_base64encoding
 
@@ -74,3 +75,100 @@ def test_public_channels_endpoint(self):
         self.assertEqual(first_channel["name"], self.channel.name)
         self.assertEqual(first_channel["id"], self.channel.id)
         self.assertEqual(first_channel["icon_encoding"], generated_base64encoding())
+
+    def test_public_channel_lookup_with_channel_version_token_uses_channel_version(
+        self,
+    ):
+        """
+        A channel version token should resolve to the matched ChannelVersion,
+        not the channel's current published version.
+        """
+        self.channel.main_tree.published = True
+        self.channel.main_tree.save()
+
+        self.channel.version = 7
+        self.channel.published_data = {
+            "2": {"version_notes": "v2 notes"},
+            "4": {"version_notes": "v4 notes"},
+            "7": {"version_notes": "v7 notes"},
+        }
+        self.channel.save()
+
+        channel_version, _created = ChannelVersion.objects.get_or_create(
+            channel=self.channel,
+            version=4,
+            defaults={
+                "kind_count": [],
+                "included_languages": [],
+                "resource_count": 0,
+                "size": 0,
+            },
+        )
+        version_token = channel_version.new_token().token
+
+        lookup_url = reverse(
+            "get_public_channel_lookup",
+            kwargs={"version": "v1", "identifier": version_token},
+        )
+        response = self.client.get(lookup_url)
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(len(response.data), 1)
+        self.assertEqual(response.data[0]["version"], 4)
+        self.assertNotEqual(response.data[0]["version"], self.channel.version)
+        self.assertEqual(
+            response.data[0]["version_notes"], {2: "v2 notes", 4: "v4 notes"}
+        )
+
+    def test_public_channel_lookup_channel_version_and_channel_tokens_have_same_keys(
+        self,
+    ):
+        """
+        Lookup responses from channel-version-token and channel-token endpoints
+        should expose the same top-level keys, even if values differ.
+        """
+        self.channel.main_tree.published = True
+        self.channel.main_tree.save()
+
+        self.channel.version = 9
+        self.channel.published_data = {
+            "3": {"version_notes": "v3 notes"},
+            "9": {"version_notes": "v9 notes"},
+        }
+        self.channel.save()
+
+        latest_channel_version, _created = ChannelVersion.objects.get_or_create(
+            channel=self.channel,
+            version=9,
+            defaults={
+                "kind_count": [],
+                "included_languages": [],
+                "resource_count": 0,
+                "size": 0,
+            },
+        )
+        latest_version_token = latest_channel_version.new_token().token
+        channel_token = self.channel.make_token().token
+
+        channel_version_response = self.client.get(
+            reverse(
+                "get_public_channel_lookup",
+                kwargs={"version": "v1", "identifier": latest_version_token},
+            )
+        )
+        channel_response = self.client.get(
+            reverse(
+                "get_public_channel_lookup",
+                kwargs={"version": "v1", "identifier": channel_token},
+            )
+        )
+
+        self.assertEqual(channel_version_response.status_code, 200)
+        self.assertEqual(channel_response.status_code, 200)
+        self.assertEqual(len(channel_version_response.data), 1)
+        self.assertEqual(len(channel_response.data), 1)
+
+        self.assertSetEqual(
+            set(channel_version_response.data[0].keys()),
+            set(channel_response.data[0].keys()),
+        )
diff --git a/contentcuration/kolibri_public/views_v1.py b/contentcuration/kolibri_public/views_v1.py
@@ -1,4 +1,5 @@
 import json
+from collections import OrderedDict
 
 from django.conf import settings
 from django.contrib.sites.models import Site
@@ -19,6 +20,8 @@
 
 from contentcuration.decorators import cache_no_user_data
 from contentcuration.models import Channel
+from contentcuration.models import ChannelVersion
+from contentcuration.serializers import get_thumbnail_encoding
 from contentcuration.serializers import PublicChannelSerializer
 
 
@@ -28,6 +31,43 @@ def _get_channel_list(version, params, identifier=None):
     raise LookupError()
 
 
+def _get_version_notes(channel, channel_version):
+    data = {
+        int(k): v["version_notes"]
+        for k, v in channel.published_data.items()
+        if int(k) <= channel_version.version
+    }
+    return OrderedDict(sorted(data.items()))
+
+
+def _serialize_channel_version(channel_version_qs):
+    channel_version = channel_version_qs.first()
+    if not channel_version or not channel_version.channel:
+        return []
+
+    channel = channel_version.channel
+    return [
+        {
+            "id": channel.id,
+            "name": channel.name,
+            "language": channel.language_id,
+            "public": channel.public,
+            "description": channel.description,
+            "icon_encoding": get_thumbnail_encoding(channel),
+            "version_notes": _get_version_notes(channel, channel_version),
+            "version": channel_version.version,
+            "kind_count": channel_version.kind_count,
+            "included_languages": channel_version.included_languages,
+            "total_resource_count": channel_version.resource_count,
+            "published_size": channel_version.size,
+            "last_published": channel_version.date_published,
+            "matching_tokens": [channel_version.secret_token.token]
+            if channel_version.secret_token
+            else [],
+        }
+    ]
+
+
 def _get_channel_list_v1(params, identifier=None):
     keyword = params.get("keyword", "").strip()
     language_id = params.get("language", "").strip()
@@ -40,6 +80,20 @@ def _get_channel_list_v1(params, identifier=None):
         )
         if not channels.exists():
             channels = Channel.objects.filter(pk=identifier)
+
+        if not channels.exists():
+            # If channels doesnt exist with the given token, check if this is a token of
+            # a channel version.
+            channel_version = ChannelVersion.objects.select_related(
+                "secret_token", "channel"
+            ).filter(
+                secret_token__token=identifier,
+                channel__deleted=False,
+                channel__main_tree__published=True,
+            )
+            if channel_version.exists():
+                # return early as we won't need to apply the other filters for channel version tokens
+                return channel_version
     else:
         channels = Channel.objects.prefetch_related("secret_tokens").filter(
             Q(public=True) | Q(secret_tokens__token__in=token_list)
@@ -96,7 +150,12 @@ def get_public_channel_lookup(request, version, identifier):
         return HttpResponseNotFound(
             _("No channel matching {} found").format(escape(identifier))
         )
-    return Response(PublicChannelSerializer(channel_list, many=True).data)
+
+    if channel_list.model == ChannelVersion:
+        channel_list = _serialize_channel_version(channel_list)
+        return Response(channel_list)
+    else:
+        return Response(PublicChannelSerializer(channel_list, many=True).data)
 
 
 @api_view(["GET"])
