-
Notifications
You must be signed in to change notification settings - Fork 22
Description
INL's continuous integration (CI) system CIVET allows for testing of external MOOSE applications like CRANE, both within their own repository (PRs, branch merges, etc.) and as part of regular MOOSE PR testing - see this page for a recent set of results on the MOOSE next branch. CRANE could benefit from this workflow, given as up until now CRANE components have been tested only locally and as part of their usage in Zapdos.
Another change I would make would be the creation of a devel branch. After a PR merge, everything would be re-tested and then merged into master only when everything is passing. The branch testing would be where you might have extended testing in the future.....at first it might have the same test configurations - we call them "recipes" - as your PRs. This workflow protects your master branch from possible failure points that might occur when multiple people are working on the code. Having a devel branch is optional, but all of the INL MOOSE apps and several external apps use this structure.
To get this rolling, we would need to perform a few things:
- Add a MOOSE submodule to CRANE (I have a branch ready to submit for this shortly).
- Add CRANE to the list of tested external applications (I would perform this internally).
- Add a MOOSE webhook that allows GitHub to communicate with CIVET when a new event (like a PR or branch merge) occurs.
- Add a set of regular CRANE test configurations for PRs and branches. Again, I would do this internally and be your point of contact if you wanted to make changes. At first, I think we should base this on those found in Zapdos.
Happy to answer any questions you might have on this!