address bugbot feedback

Author: keelerm84

ldclient/impl/datasourcev2/polling.py

@@ -20,7 +20,7 @@
     IntentCode,
     PutObject,
     Selector,
-    ServerIntent
+    ServerIntent,
 )
 from ldclient.impl.http import _http_factory
 from ldclient.impl.repeating_task import RepeatingTask
@@ -33,7 +33,7 @@
     _Success,
     http_error_message,
     is_http_error_recoverable,
-    log
+    log,
 )
 
 POLLING_ENDPOINT = "/sdk/poll"
@@ -162,11 +162,11 @@ def fetch(self, selector: Optional[Selector]) -> PollingResult:
         if selector is not None:
             query_params["selector"] = selector.state
 
+        uri = self._poll_uri
         if len(query_params) > 0:
             filter_query = parse.urlencode(query_params)
-            self._poll_uri += f"?{filter_query}"
+            uri += f"?{filter_query}"
 
-        uri = self._poll_uri
         hdrs = _headers(self._config)
         hdrs["Accept-Encoding"] = "gzip"
 

ldclient/impl/datasystem/protocolv2.py

@@ -212,13 +212,13 @@ def from_dict(data: dict) -> "DeleteObject":
         Deserializes a DeleteObject from a JSON-compatible dictionary.
         """
         version = data.get("version")
-        kind = ObjectKind(data.get("kind"))
+        kind = data.get("kind")
         key = data.get("key")
 
         if version is None or kind is None or key is None:
             raise ValueError("Missing required fields in DeleteObject JSON.")
 
-        return DeleteObject(version=version, kind=kind, key=key)
+        return DeleteObject(version=version, kind=ObjectKind(kind), key=key)
 
 
 @dataclass(frozen=True)
@@ -261,14 +261,16 @@ def from_dict(data: dict) -> "PutObject":
         Deserializes a PutObject from a JSON-compatible dictionary.
         """
         version = data.get("version")
-        kind = ObjectKind(data.get("kind"))
+        kind = data.get("kind")
         key = data.get("key")
         object_data = data.get("object")
 
         if version is None or kind is None or key is None or object_data is None:
             raise ValueError("Missing required fields in PutObject JSON.")
 
-        return PutObject(version=version, kind=kind, key=key, object=object_data)
+        return PutObject(
+            version=version, kind=ObjectKind(kind), key=key, object=object_data
+        )
 
 
 @dataclass(frozen=True)