code review feedback

Author: keelerm84

contract-tests/async_stream_entity.py

@@ -36,16 +36,17 @@ async def run(self):
         try:
             self.log.info('Opening stream from %s', stream_url)
 
-            request_options = {}
-            if self.options.get("readTimeoutMs") is not None:
-                request_options["timeout"] = aiohttp.ClientTimeout(
-                    sock_read=millis_to_seconds(self.options.get("readTimeoutMs"))
-                )
-
+            # Always set total=None to disable aiohttp's default 5-minute total
+            # timeout, which would silently kill long-lived SSE connections.
             connect = AsyncConnectStrategy.http(
                 url=stream_url,
                 headers=self.options.get("headers"),
-                aiohttp_request_options=request_options if request_options else None,
+                aiohttp_request_options={
+                    "timeout": aiohttp.ClientTimeout(
+                        total=None,
+                        sock_read=millis_to_seconds(self.options.get("readTimeoutMs")),
+                    )
+                },
             )
             sse = AsyncSSEClient(
                 connect,

ld_eventsource/async_client.py

@@ -134,7 +134,8 @@ async def _all_generator(self):
                 if result is not None:
                     yield result
 
-            lines = _AsyncBufferedLineReader.lines_from(self.__connection_result.stream)
+            current_result = self.__connection_result
+            lines = _AsyncBufferedLineReader.lines_from(current_result.stream)
             reader = _AsyncSSEReader(lines, self.__last_event_id, None)
             error: Optional[Exception] = None
             try:
@@ -143,14 +144,14 @@ async def _all_generator(self):
                     yield ec
                     if self.__interrupted:
                         break
-                self.__connection_result = None
             except Exception as e:
                 if self.__closed:
                     return
                 error = e
-                self.__connection_result = None
             finally:
                 self.__last_event_id = reader.last_event_id
+                await current_result.close()
+                self.__connection_result = None
 
             self._compute_next_retry_delay()
             fail_or_continue, self.__current_error_strategy = (